Remove default ENV to allow user provide environment variables via env files #3925
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ileodo is attempting to deploy a commit to the NextChat Team on Vercel. A member of the Team first needs to authorize it. |
|
Your build has completed! |
fredliang44
reviewed
Jan 26, 2024
| @@ -31,9 +31,6 @@ WORKDIR /app | |||
| RUN apk add proxychains-ng | |||
|
|
|||
| ENV PROXY_URL="" | |||
| ENV OPENAI_API_KEY="" | |||
There was a problem hiding this comment.
It would be better commenting the env variables so that people would know what env to set when using this docker image
There was a problem hiding this comment.
maybe those documentations can stay in the readme file?
|
@ileodo I'm assuming you are going to mount |
|
yep. |
|
any chance to get an approval on this? thx |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NextJS app allow user define environment variables by providing a
.env.localfile in/app/.Those related lines in the Dockerfile are setting values to the environment variables, which will be passed in as
process.env, which ranked as the top one in the loading orderThis PR is removing these default variables so that user can just mount a
.env.localfile to set environment variable, which can avoid include the sensitive information in the docker-compose file.