Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix the problem of error at download the screenshot picture when there are some pics in messages history #3554

Closed

Conversation

tomridder
Copy link

之所以报错是因为 消息记录中的图片不属于私域中的图片 ,需要在toPNG之前 用一个后台接口转换为私域的图片地址,然后toPNG则不会报错可以正常下载 #3553

下面是 修复后的功能截图

动物
快乐

@H0llyW00dzZ
Copy link
Contributor

lgtm, sadly I can't cherry pick commit this branch because bug still not fixed yet

@tomridder
Copy link
Author

lgtm

i think it is solved ... you can add gpt-4v model and test it ...it is solved ...
these pic tells everythong
下载

@tomridder
Copy link
Author

it we don't add the transferimg api and there's the pics in the chat history , toPNG method will go some error because the pic don't belong to this domain .

that's why we need to add the transferimg api

@H0llyW00dzZ
Copy link
Contributor

it we don't add the transferimg api and there's the pics in the chat history , toPNG method will go some error because the pic don't belong to this domain .

that's why we need to add the transferimg api

yeah because of cors issue, been known it

@H0llyW00dzZ
Copy link
Contributor

I cherry pick pr this to my fork
https://hackerchat.btz.sh/#/changelog

Copy link

vercel bot commented Feb 15, 2024

@tomridder is attempting to deploy a commit to the NextChat Team on Vercel.

A member of the Team first needs to authorize it.

Copy link
Contributor

Your build has completed!

Preview deployment

@Dean-YZG
Copy link
Contributor

thanks a lot for your works, it's a good way to solve cross-domain problems, but it would lead to a ssrf

@Dean-YZG Dean-YZG closed this Mar 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants