Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reopen #443 according to #364 #546

Closed
wants to merge 19 commits into from
Closed

Conversation

eamanu
Copy link
Contributor

@eamanu eamanu commented Jun 10, 2017

Fix bugs

eamanu added 17 commits May 31, 2017 23:00
The twitter_api.Twitter.PostTwitter(message) receive a message and make a Tweet
Is necessary have a twitter_api.secret like github_pat.secret with the next format
consumer_key='1234...'
consumer_secret='1234...'
access_token='12345...'
access_secret='1234...'

Todo List:
1. Test twitter_api
1. create a Twitter Apps (https://apps.twitter.com/) for ChaosBot and complete the twitter_api.secret
fix some bugs
add new twitter post
@eamanu eamanu mentioned this pull request Jun 10, 2017
@mark-i-m
Copy link
Contributor

Hmm... permissions errors on CI build

@mark-i-m
Copy link
Contributor

Ah, I just saw #547

@PlasmaPower
Copy link
Contributor

https://twitter.com/ChaobotsC/status/873593020997713920

@chaosbot
Copy link
Collaborator

⚠️ This PR has reached its extended voting window, but it does not have a positive meritocracy review.

Please review: @PlasmaPower @phil-r @md678685 @amoffat @eukaryote31 @xyproto @mark-i-m @rhengles @andrewda @rudehn @muchzer @Smittyvb @hongaar

@PlasmaPower
Copy link
Contributor

If you'd like, I could fix the API tokens and encryption and everything, then resubmit. This isn't getting passed without proper handling of the tokens.

@chaosbot
Copy link
Collaborator

⛔ PR rejected with a vote of 4 for and 1 against, a weighted total of 3.0 and a threshold of 6.0, and NO current meritocracy review.

Open a new PR to restart voting.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants