Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Xccl process group for Pytorch #1

Closed
wants to merge 1,018 commits into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1018 commits
Select commit Hold shift + click to select a range
0f8c7e4
[ONNX] Fix symbolic values and numpy implementation (#135786)
justinchuby Sep 12, 2024
f5d5759
Allow optional positional arguments for `torch.func.functional_call` …
why-in-Shanghaitech Sep 12, 2024
ea51a8b
Use a better decomposition for split_with_sizes (#135728)
isuruf Sep 11, 2024
f6bc78a
[AOTI][Tooling] Support debug printing for inductor level extern kern…
YUNQIUGUO Sep 12, 2024
ced4af1
[DSD] Fix distributed state dict full_state_dict option hang during s…
wz337 Sep 12, 2024
4e4539d
NJT <-> padded dense conversions (#125947)
jbschlosser Sep 12, 2024
c67fe13
Add batching rule for torch.scatter_reduce (#135547)
guilhermeleobas Sep 10, 2024
6bfcaa6
[torch][fx] Add new replacement_callback to materialize a replacement…
dulinriley Sep 12, 2024
0519f2d
Pass ideep:lowp_kind to matmul_forward::compute on cache misses (#135…
fadara01 Sep 12, 2024
9257670
[export] ignore mark_dynamic() in export (#135536)
pianpwk Sep 12, 2024
396b444
Validate input types for `torch.nn.Linear` and `torch.nn.Bilinear` (#…
sanskarmodi8 Sep 12, 2024
e2bcb9d
Revert "[DSD] Fix distributed state dict full_state_dict option hang …
pytorchmergebot Sep 12, 2024
9b1cdf5
Revert "Check function declarations of Core ML code (#135467)"
pytorchmergebot Sep 12, 2024
aed4311
[dynamo] support torch.nn.attention.sdpa_kernel context manager (#135…
williamwen42 Sep 12, 2024
254d7d9
[Easy] Check if quant registered in constant folding (#135875)
eellison Sep 12, 2024
2e123c8
[ROCm] Use ieee precision for fp32 in flex attention (#135702)
jataylo Sep 12, 2024
1828571
[FlexAttention] Ensure q/k/v and block_mask on excact the same device…
yanboliang Sep 12, 2024
b1f308d
fix compiled_autograd deadlock throw (#135795)
majian4work Sep 12, 2024
6e646e0
[aoti] Fix workspace generation for triton (#135552)
yushangdi Sep 12, 2024
57bda41
Update nightly PyTorch version to 2.6.0 (#135916)
malfet Sep 13, 2024
1ba62e4
do not expand in replace/simplify if no changes (#135863)
isuruf Sep 12, 2024
eb5570a
[inductor] Remove unused check (#135787)
jansel Sep 12, 2024
cc08e0e
[inductor] Optimize can_fuse_vertical() (#135788)
jansel Sep 12, 2024
5098046
[inductor] Use TracerBase directly in LoopBody (#135820)
jansel Sep 12, 2024
7699781
[fx] Minor optimization in create_arg (#135821)
jansel Sep 12, 2024
4a78f2a
[fx] Replace _snake_case with a regexp (#135822)
jansel Sep 12, 2024
cebd19b
[Docs] fix inconsistent docs in conv1d, conv2d, and conv3d (#135894)
PaliC Sep 13, 2024
e36c7f8
[Inductor] Disable TF32 in `test_slice_scatter_reinplace` (#135709)
eqy Sep 13, 2024
6d1285f
[dynamo] Fix support for classmethod(property(...)) (#134968)
jansel Sep 12, 2024
077dc25
Fix lint errors in fbcode (#135614)
aorenste Sep 13, 2024
13f56c1
[Profiler] Torch Profiler distributed info is not JSON serializable (…
sraikund16 Sep 13, 2024
21abb34
[BE] Use `C10_UNUSED` (#135914)
malfet Sep 13, 2024
8ed71a9
Fix xpu memory stats error (#135818)
guangyey Sep 12, 2024
38cb0c7
[ROCm] skip test_fp8_cast_and_t on non-MI300 machines (#135917)
pragupta Sep 13, 2024
34920e4
[DSD] Fix distributed state dict full_state_dict option hang during s…
wz337 Sep 12, 2024
07673d7
real tensor prop for composite ops (#135717)
pianpwk Sep 13, 2024
62b815c
[DCP][DSD] Add a test case to demonstrate the workaround to load full…
wz337 Sep 12, 2024
b4a37b4
[inductor] More fixes on the keys of `constants` and `signature` dict…
Jokeren Sep 13, 2024
e86ba13
[Inductor UT] Generalize inductor UT for intel GPU (Part 2) (#134556)
hoshibara Sep 13, 2024
6ee0026
[Inductor UT] Generalize device-bias code in test_triton_kernels.py i…
etaf Sep 12, 2024
f3613ca
[inductor] Remove the batch fusion passes from being a default (#135922)
anijain2305 Sep 13, 2024
a203fc2
remove fast_flush arguments (#135387)
int3 Sep 13, 2024
3b411e3
[Dynamo] Use custom backend to reenter metadata tf mode when tracing …
mlazos Sep 11, 2024
18665e5
[Dynamo] Trace torch function modes entered outside of torch.compile …
mlazos Sep 12, 2024
2f830e6
[Dynamo] Support thread local setattr (#135443)
mlazos Sep 12, 2024
6ec2fa8
[Dynamo] Simplify torch function mode stack guard (#135444)
mlazos Sep 12, 2024
99a4bdb
[Dynamo] Trace enter/exit of TorchFunctionModes (#135422)
mlazos Sep 12, 2024
1d17383
[Dynamo] Remove ignored modes workaround (#135502)
mlazos Sep 12, 2024
3f7be50
[Dynamo] Remove ignored modes from torch function mode stack guard (#…
mlazos Sep 12, 2024
611cc42
[Distributed] add FP8 support to NaN checker (#135891)
kwen2501 Sep 13, 2024
f1bee4c
Update document for autocast on CPU (#135299)
CaoE Sep 13, 2024
fc90d77
[AOTI][reland] Fix assert_function call in cpu autotune template (#13…
desertfire Sep 13, 2024
46097f0
Revert "[dynamo] Fix support for classmethod(property(...)) (#134968)"
pytorchmergebot Sep 13, 2024
e2ad410
Revert "[PT2][inductor][Optimus] Add pad_aten_mm_pass pattern to reso…
pytorchmergebot Sep 13, 2024
f4df4fb
Revert "[Dynamo] Remove ignored modes from torch function mode stack …
pytorchmergebot Sep 13, 2024
1d2bdce
Revert "[Dynamo] Remove ignored modes workaround (#135502)"
pytorchmergebot Sep 13, 2024
e6f44ac
Revert "[Dynamo] Trace enter/exit of TorchFunctionModes (#135422)"
pytorchmergebot Sep 13, 2024
317e0d1
Revert "[Dynamo] Simplify torch function mode stack guard (#135444)"
pytorchmergebot Sep 13, 2024
46c3acc
Revert "[Dynamo] Support thread local setattr (#135443)"
pytorchmergebot Sep 13, 2024
56d4ea8
Revert "[Dynamo] Trace torch function modes entered outside of torch.…
pytorchmergebot Sep 13, 2024
12fc5c4
Revert "[Dynamo] Use custom backend to reenter metadata tf mode when …
pytorchmergebot Sep 13, 2024
844bdd3
Remove cycle dependency by localizing the import. (#135926)
laithsakka Sep 13, 2024
566040e
[CUDA][FP8] Skip rowwise scaling test on sm89 (#135718)
eqy Sep 13, 2024
1a96117
Fix "expand: SymIntArrayRef expected to contain only concrete integer…
ezyang Sep 13, 2024
7e1d468
Add remote cache time saved to compilation metrics (#135490)
jamesjwu Sep 13, 2024
507e9af
[FlexAttention] Fix output layout (#135882)
drisspg Sep 13, 2024
c16141e
Revert "Fix clang-tidy warnings in Caffe2 code (#134935)"
pytorchmergebot Sep 13, 2024
2423d45
[ROCm] Enable ROCm support for inductor's dynamic_rblock_scaling (#1…
jataylo Sep 13, 2024
4eae0d9
Revert "Pass ideep:lowp_kind to matmul_forward::compute on cache miss…
pytorchmergebot Sep 13, 2024
f613c03
[AOTI][Tooling] Add stats summary (mean/min/max, etc) for jit inducto…
YUNQIUGUO Sep 13, 2024
aab706d
[trymerge] Manually close merged PR when Github fails (#135890)
clee2000 Sep 13, 2024
227bfec
Revert "[aoti] Fix workspace generation for triton (#135552)"
pytorchmergebot Sep 13, 2024
c5d026a
[gpu-profiler] Expose active and repeat in os env var (#135757)
dshi7 Sep 13, 2024
4172569
Revert "[Inductor] Rename `cpp_wrapper_cuda.py` as `cpp_wrapper_gpu.p…
pytorchmergebot Sep 13, 2024
7d6f92c
Revert "Validate input types for `torch.nn.Linear` and `torch.nn.Bili…
pytorchmergebot Sep 13, 2024
bf783dc
fix requirements.txt installation failure issue on Windows (#134567)
jingxu10 Sep 13, 2024
5c2dbae
Fix script name in the comments (#135507)
kit1980 Sep 13, 2024
03f617f
[reland][export] fix re-export custom metadata (#135720)
yiming0416 Sep 13, 2024
8a5f0f0
Use python 3.11 for Large Wheel build (#136042)
atalman Sep 13, 2024
b0230d3
Add gpu and gpu_dynamic versions of add_loop (#135809)
laithsakka Sep 13, 2024
02b75c1
Only measure compile time instruction count for sum_floordiv benchmar…
laithsakka Sep 13, 2024
b611999
Reduce default iterations to 5 . (#135773)
laithsakka Sep 13, 2024
fd28c98
Fix bug in split-build workflows codegen (#136043)
malfet Sep 13, 2024
de1216b
Fix inductor-micro-benchmark results upload (take 2) (#136052)
huydhn Sep 13, 2024
b74119c
[MTIA tensor] allow shallow copy between CPU and MTIA tensors (#135871)
jvandebon Sep 13, 2024
a20c3a4
[ONNX] Remove logging apis from public (#133825)
justinchuby Sep 13, 2024
ba9a8f7
Cleanup unused runner variants (#136058)
ZainRizvi Sep 13, 2024
677a686
[PT2][Inductor][Optimus] Fix a corner case in remove_split_with_size_…
mengluy0125 Sep 13, 2024
37283a2
Fix attr check for quantization spec (#135736)
jerryzh168 Sep 12, 2024
df40c42
[Easy] Dont match to mm_plus_mm if not in max autotune (#135929)
eellison Sep 13, 2024
3212730
[3.13] fix 3.13 pickle error in serialization.py (#136034)
williamwen42 Sep 13, 2024
546a0eb
[Distributed] add pack-check method for float8_e4m3fn (#135961)
kwen2501 Sep 13, 2024
3f9ead0
[BE] Use squeeze/unsqueeze in im2col (#136006)
malfet Sep 14, 2024
9d3f7ea
Fix sum() forward for NJT (#131945)
jbschlosser Sep 13, 2024
154834d
[Inductor UT] Generalize inductor UT for intel GPU (Part 3) (#135827)
hoshibara Sep 14, 2024
fe70664
[CI] Check that PyTorch is built with OpenMP (#136060)
malfet Sep 14, 2024
73e5c70
Fix tensor.data_ptr() representation overflow (#135567)
guangyey Sep 10, 2024
3f2693f
Use _amp_foreach_non_finite_check_and_unscale_ for CPU grads of Shard…
CaoE Sep 14, 2024
8c3dedd
Revert "Use _amp_foreach_non_finite_check_and_unscale_ for CPU grads …
pytorchmergebot Sep 14, 2024
bd71fee
[Dynamo] Use custom backend to reenter metadata tf mode when tracing …
mlazos Sep 13, 2024
4bab849
[Dynamo] Trace torch function modes entered outside of torch.compile …
mlazos Sep 13, 2024
04996be
[Dynamo] Support thread local setattr (#135443)
mlazos Sep 13, 2024
e684dc6
[Dynamo] Simplify torch function mode stack guard (#135444)
mlazos Sep 13, 2024
54999a5
[Dynamo] Trace enter/exit of TorchFunctionModes (#135422)
mlazos Sep 13, 2024
88fa33b
[Dynamo] Remove ignored modes workaround (#135502)
mlazos Sep 13, 2024
aeae1d4
[Dynamo] Remove ignored modes from torch function mode stack guard (#…
mlazos Sep 13, 2024
274a5ae
[TCPStore] Remove deprecated constructor (#136004)
fduwjj Sep 13, 2024
af3506a
[ROCm] Skip pointwise associative scan tests due to regression (#135995)
jataylo Sep 14, 2024
b634f52
[MPS] Add native im2col (#135706)
malfet Sep 14, 2024
90422d9
Disable garbage collection during compile_time_instructions count in …
laithsakka Sep 13, 2024
3e6c904
[CI] Increase open file handles limit to 16K on MacOS (#136061)
malfet Sep 14, 2024
293eb37
[Traceable FSDP2] Don't register RegisterPostBackwardFunction if user…
yf225 Sep 13, 2024
7b52775
Add higher order operator name to the cache bypass exception (#135876)
oulgen Sep 13, 2024
e911425
[Traceable FSDP2][Partitioner] Must save AC output if output has a ba…
yf225 Sep 14, 2024
d6a5fdb
Use _amp_foreach_non_finite_check_and_unscale_ for CPU grads of Shard…
CaoE Sep 14, 2024
41bf3be
OpenReg: Fix issue when copying on the same device (#135956)
Zhenbin-8 Sep 14, 2024
ae4e145
Revert "[Dynamo] Remove ignored modes from torch function mode stack …
pytorchmergebot Sep 14, 2024
7831fd9
Revert "[Dynamo] Remove ignored modes workaround (#135502)"
pytorchmergebot Sep 14, 2024
3379c61
Revert "[Dynamo] Trace enter/exit of TorchFunctionModes (#135422)"
pytorchmergebot Sep 14, 2024
7af61fa
Revert "[Dynamo] Simplify torch function mode stack guard (#135444)"
pytorchmergebot Sep 14, 2024
94cdd7f
Revert "[Dynamo] Support thread local setattr (#135443)"
pytorchmergebot Sep 14, 2024
5253820
Revert "[Dynamo] Trace torch function modes entered outside of torch.…
pytorchmergebot Sep 14, 2024
5b5901d
Revert "[Dynamo] Use custom backend to reenter metadata tf mode when …
pytorchmergebot Sep 14, 2024
28fe3fa
Add Half support for reflection and replication padding on CPU (#135931)
CaoE Sep 14, 2024
9ef8f62
[3.13] fix 3.13 pickle error in torch/package (#136049)
williamwen42 Sep 13, 2024
d3eb38a
[Pytorch] Consolidate Strobelight compile time profiler between OSS a…
kollasb Sep 14, 2024
f448c82
Only keep ListOfLinears module in basic_modules_benchmarks and add gp…
laithsakka Sep 13, 2024
7380d47
[AOTI] Fix a fallback op returning None issue (#135997)
desertfire Sep 13, 2024
ff59b62
[Dynamo] Use custom backend to reenter metadata tf mode when tracing …
mlazos Sep 14, 2024
659bee2
[Dynamo] Trace torch function modes entered outside of torch.compile …
mlazos Sep 14, 2024
a72c29a
[Dynamo] Support thread local setattr (#135443)
mlazos Sep 14, 2024
0371158
[Dynamo] Simplify torch function mode stack guard (#135444)
mlazos Sep 14, 2024
a87bf5b
[Dynamo] Trace enter/exit of TorchFunctionModes (#135422)
mlazos Sep 14, 2024
4019089
[Dynamo] Remove ignored modes workaround (#135502)
mlazos Sep 14, 2024
2366469
[Dynamo] Remove ignored modes from torch function mode stack guard (#…
mlazos Sep 14, 2024
7056c5b
[BE][Ez]: Update pybind11 to 2.13.6. Exposes new conduit cross-compat…
Skylion007 Sep 14, 2024
6d4db5b
[dynamo] Fix support for classmethod(property(...)) (#134968)
jansel Sep 14, 2024
d01f579
[BE]: Update mypy to 1.11.2 (#133816)
Skylion007 Sep 14, 2024
41bd750
Add Triton CPU as an Inductor backend (#133408)
int3 Sep 13, 2024
4d548a6
Add CI for Triton CPU backend (#135342)
int3 Sep 13, 2024
c032521
Fix dividing Mul by factor (#136079)
isuruf Sep 14, 2024
75925ae
use a fast expand algorithm (#135999)
isuruf Sep 13, 2024
8b5957f
Add TensorReferenceAnalysis and some tests (#135886)
bobrenjc93 Sep 14, 2024
1199f5f
Optimize dict reconstruct to not codegen untouched values (#134876)
guilhermeleobas Sep 12, 2024
d9185e1
SKIP llama for dynamic size testing (#135960)
leslie-fang-intel Sep 13, 2024
1054a5f
[Traceable FSDP2] Ignore FSDP2 forward hook side-effects in AC; Suppo…
yf225 Sep 14, 2024
e63e794
[audio hash update] update the pinned audio hash (#136106)
pytorchupdatebot Sep 15, 2024
343d153
Fix redundant move warnings by g++ (#134987)
cyyever Sep 15, 2024
c509f72
Revert "[Pytorch] Consolidate Strobelight compile time profiler betwe…
pytorchmergebot Sep 15, 2024
4bc7d45
Deprecate _preserve_ops and consolidate with decomp_table (#135080)
tugsbayasgalan Sep 14, 2024
af41162
Create export_for_inference API and expose core_aten as public facing…
tugsbayasgalan Sep 15, 2024
c87301c
Add some doc for export_for_training (#135918)
tugsbayasgalan Sep 15, 2024
634d85a
[pytorch][monitoring] Dynamic backend for WaitCounter (#135967)
andriigrynenko Sep 15, 2024
dbe83ff
Add decomposition for permute_copy (#130944)
rec Sep 10, 2024
17f48c5
Update link in distributed.tensor.parallel.rst (#136103)
H-Huang Sep 15, 2024
270ba69
[Distributed] add pack-check method for float8_e5m2 (#136115)
kwen2501 Sep 15, 2024
87f092d
[dynamo] simplify implementation for `functools.reduce` (#133778)
XuehaiPan Sep 14, 2024
9717767
[dynamo] simplify implementation for `builtins.sum` (#133779)
XuehaiPan Sep 14, 2024
2e23a4b
Revert "[BE]: Update mypy to 1.11.2 (#133816)"
pytorchmergebot Sep 16, 2024
bade051
Add python 3.13.0t build to Docker images (#136001)
atalman Sep 16, 2024
4ca094b
[AOTI] Refactor how cpp_wrapper specific options are set (#136035)
desertfire Sep 14, 2024
ac9b029
[reland][Inductor] Rename `cpp_wrapper_cuda.py` as `cpp_wrapper_gpu.p…
desertfire Sep 16, 2024
c916df0
Delete stable prototype (#135911)
bigfootjon Sep 16, 2024
0f22d78
Add decomposition for squeeze_copy (#130941)
rec Sep 16, 2024
15c04bd
[effects] Turn off dtype promotion for with_effects lowering (#136039)
IvanKobzarev Sep 13, 2024
ac3c0a0
[ONNX] Run type promotion test in CI and update the table (#135915)
justinchuby Sep 16, 2024
992cad8
[BE][Ez]: Add full half/bfloat16 dtype for `unique` and `isin` (#136114)
Skylion007 Sep 16, 2024
c1fd5c0
Revert "[inductor] More fixes on the keys of `constants` and `signatu…
pytorchmergebot Sep 16, 2024
6ca6c63
[Pytorch] Cleanup Strobelight URL and shorten for readability (#136102)
kollasb Sep 16, 2024
1712cd6
[BE][Ez]: Fix missing float16 coverage for adaptive_pool3d_cpu (#136091)
Skylion007 Sep 16, 2024
7136fe1
Revert "Add CI for Triton CPU backend (#135342)"
pytorchmergebot Sep 16, 2024
07f1b26
Revert "Add Triton CPU as an Inductor backend (#133408)"
pytorchmergebot Sep 16, 2024
1978af3
Remove accidentally committed code (#136154)
malfet Sep 16, 2024
2554acd
`torch.nn.MultiheadAttention`: docs: improvement (#136111)
kuraga Sep 16, 2024
e7527ad
Drop outdated section 'Running clang-tidy' in CONTRIBUTING.md (#136146)
eugenekoran Sep 16, 2024
18c39b9
[Distributed] fix FileSystemWriter __init__ (#136135)
kwen2501 Sep 16, 2024
5a20276
[EZ] Fix spelling typo (#136157)
malfet Sep 16, 2024
1b7cd2d
[BE]: Update mypy to 1.11.2 (#133816)
Skylion007 Sep 16, 2024
1c3418a
Refactor FxGraphCache.load into separate functions, so that AOTAutogr…
jamesjwu Sep 16, 2024
225ea8f
[c10d][Reland] Remove Option for ProcessGroup and Expose backend Opti…
fduwjj Sep 11, 2024
0d8d3be
[torch/multiprocessing] Use multiprocessing.reduction.register Forki…
kiukchung Sep 16, 2024
52bad41
Use ncclAlltoAllv and ncclAlltoAll API when supported (#134499)
dsjohns2 Sep 16, 2024
3b683d0
Revert "[dynamo] Fix support for classmethod(property(...)) (#134968)"
pytorchmergebot Sep 16, 2024
9797529
Add scaling arguments to bsr_dense_addmm (#136104)
pearu Sep 16, 2024
163d433
[ONNX] Treat CompositeImplicitAutograd ops as normal ops in decomp (#…
justinchuby Sep 16, 2024
4aead15
use csv extention for test report in order for it to be uploaded to s…
laithsakka Sep 16, 2024
e6aae77
Revert "fix compiled_autograd deadlock throw (#135795)"
pytorchmergebot Sep 16, 2024
a2d3e64
Back out "Flip triton kernel default layout constraint to "needs_fixe…
tissue3 Sep 17, 2024
865ef8f
inductor: dont use default_dtype during rng functionalization (#136041)
bdhirsh Sep 14, 2024
aa3b052
make view.dtype always return an alias (#136074)
bdhirsh Sep 14, 2024
bec3669
[DSD][EZ] Minor update in _state_dict_utils.py (#136165)
wz337 Sep 16, 2024
4434084
Update real device in FSDP state_dict_utils (#134994)
ankurneog Sep 17, 2024
70427fb
Revert "Optimize dict reconstruct to not codegen untouched values (#1…
pytorchmergebot Sep 17, 2024
b20e5aa
Revert "Add decomposition for squeeze_copy (#130941)"
pytorchmergebot Sep 17, 2024
da39dbe
Revert "Add decomposition for permute_copy (#130944)"
pytorchmergebot Sep 17, 2024
df1bf35
Don't run reshape pattern match on dynamic shape size tensor (#136100)
ezyang Sep 17, 2024
97108d0
Add back optim type hints that were lost when *.pyi files were remove…
mauvilsa Sep 17, 2024
7c1ed25
[ONNX] Fix numpy method to return the correct type (#136162)
justinchuby Sep 17, 2024
e5f33a2
[Fix]: Update CPUINFO submodule to fix support for NON-SVE ARM Hardwa…
ng-05 Sep 17, 2024
564b000
[PT2] Port merge_concats_pass to PT2 pre_grad passes (#135527)
huxintong Sep 17, 2024
7541614
[MTIA] Support torch.cuda.get_device_capability equivalent API on MTI…
ttrung149 Sep 17, 2024
2e928a8
Delete links to non-existing `run_plan_mpi.cc` (#136204)
malfet Sep 17, 2024
0d33cd9
Support rms_norm() for NJT (#135872)
jbschlosser Sep 17, 2024
6c711de
[export] Deserialize args with python keyword names (#136036)
angelayi Sep 17, 2024
6fbb26b
[TorchRec][PT2 IR][APF] short circuit the flatten/unflatten between E…
TroyGarden Sep 17, 2024
abfa305
[NCCL] Don't override `waitUntilInitialized`'s setting of `comm->init…
eqy Sep 17, 2024
fb7108e
[PyTorch CUDA Allocator] Allow reuse of non-split blocks with better …
banitag1 Sep 17, 2024
f6b55c5
[PyTorch Pinned Allocator] Add support of background thread to proces…
banitag1 Sep 17, 2024
943303f
[MPS] Fix 5D+ reductions over negative dimentions (#136198)
malfet Sep 17, 2024
4d8f1e3
[c10d] remove sleep from watchdogHandler (#135760)
c-p-i-o Sep 18, 2024
5127c4b
[AO][Inductor] Enable WOQ fusion pattern with permute (#135928)
leslie-fang-intel Sep 13, 2024
2781cb8
[BE] Make `NestedTensorTransformerFunctions.cu` compilable without wa…
malfet Sep 18, 2024
ab9a171
[torch/numpy][numpy2.0 compat] Additional changes for tests to run u…
kiukchung Sep 18, 2024
591bb41
[CI] Make linux-aarch64 shards actually running different tests (#136…
malfet Sep 18, 2024
1450dcd
[dynamo] Fix support for classmethod(property(...)) (#134968)
jansel Sep 17, 2024
d81663c
Reland D62220158 (#136213)
mengluy0125 Sep 18, 2024
feee7dd
Fix ROCm skip decorator for test_ddp_tp and multiprocess UTs (#136161)
pragupta Sep 18, 2024
4dd3a18
[Inductor] Increase multiplier to 3 for Inductor AMP FP16 benchmark c…
jiayisunx Sep 13, 2024
091cb37
Fix fast_expand recursion error (#136163)
isuruf Sep 16, 2024
79f2421
Add _addmm_activation to lower precision cast policy on AutocastCPU (…
CaoE Sep 18, 2024
1c33f7f
[PyTorch] Remove unnecessary include of c10/util/Exception.h in irang…
swolchok Sep 17, 2024
645c454
[c10d] Make test compatible for new pytest (#136158)
fduwjj Sep 17, 2024
5ef2ad1
[ROCm] upgrade ROCm CI builds to py3.10 (#134108)
jataylo Sep 18, 2024
68da9bb
Extending the Pytorch vec backend for SVE (ARM) (#119571)
maajidkhann Sep 18, 2024
df249ed
[cuDNN][conv][A100] Bump tolerances for `vmap_autograd_grad` `conv2d`…
eqy Sep 18, 2024
4814341
Add wait counter for nccl abort (#136067)
atuljangra Sep 18, 2024
01db0e8
Fix calling Add._from_args and Mul._from_args (#136143)
isuruf Sep 16, 2024
3cd03e2
[Traceable FSDP2] Minor refactor to traceable FSDP2 unit tests (#136219)
yf225 Sep 18, 2024
09cb80c
[dynamo]Remove stream hardcoding in dynamo VariableBuilder (#131763)
siju-samuel Sep 18, 2024
0073d10
[BE][MPS] Delete duplicated code in `View.mm` (#136295)
malfet Sep 18, 2024
f39faaa
[BE][MPS] Fix deprecation warnings on MacOS 15.0 (#136292)
malfet Sep 18, 2024
5ea1746
Add uint16 support for observer (#136238)
jerryzh168 Sep 18, 2024
80970ab
[dynamo] fix crash in InspectSignatureVariable (#136010)
williamwen42 Sep 17, 2024
82d9db2
Add type checks for Tensor.add_ (#135864)
DuyguA Sep 19, 2024
a894673
XFAIL test_segfault (#136252)
huydhn Sep 19, 2024
c410555
Return unsafe_view instead of view from matmul when folding occurs (#…
jwieczorekhabana Sep 19, 2024
1c81370
[CODEMOD][caffe2] use npt.NDArray instead of np.ndarray in type annot…
igorsugak Sep 19, 2024
f0c3fa3
Revert "Reland D62220158 (#136213)"
pytorchmergebot Sep 19, 2024
e6609f8
[FSDP2] Fixed 2D mismatched grad placements (#136237)
awgu Sep 18, 2024
ee071e0
Log structured logging overhead to dynamo compile (kinda) (#136142)
jamesjwu Sep 19, 2024
3d38f28
Type _sympy/functions.py [1/n] (#136205)
bobrenjc93 Sep 19, 2024
f37b895
[ROCm] Enable Flex attention tests on AMD gpus (#136245)
jerrymannil Sep 19, 2024
6252f21
fix stride compare failed when size value equal to one in ForeachUtil…
Shan19900305 Sep 19, 2024
5687391
[AOTI][Tooling][8/n] Add option to pinpoint kernel names in debug pri…
YUNQIUGUO Sep 19, 2024
dd3c89f
add basic_modules_ListOfLinears_inductor_gpu_force_shape_pad (#136175)
laithsakka Sep 17, 2024
2d4a478
[22/N] Fix clang-tidy warnings in jit (#134829)
cyyever Sep 19, 2024
c574ab3
DTensor: dont hash symint tensor input in propagate_tensor_meta (#136…
bdhirsh Sep 18, 2024
0e9e7d3
[CI][CUSPARSELT] Extend cusparselt installation script to support cud…
nWEIdia Sep 19, 2024
fa5087b
TCPStoreLibUvBackend: trace operations (#136320)
d4l3k Sep 20, 2024
c9d6bb8
passing FileTimerRequests.to_json() to log_debug_info_for_expired_tim…
felixsu2006 Sep 20, 2024
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
The table of contents is too big for display.
Diff view
Diff view
  •  
  •  
  •  
6 changes: 3 additions & 3 deletions .ci/docker/aotriton_version.txt
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
0.6b
0.7b
manylinux_2_17
rocm6.2
7f07e8a1cb1f99627eb6d77f5c0e9295c775f3c7
e4ab195d2bd19e939c675a13280c29714c6ef9f2cf420690da150fa0cac043b1
9be04068c3c0857a4cfd17d7e39e71d0423ebac2
3e9e1959d23b93d78a08fcc5f868125dc3854dece32fd9458be9ef4467982291
28 changes: 14 additions & 14 deletions .ci/docker/build.sh
Original file line number Diff line number Diff line change
Expand Up @@ -236,7 +236,7 @@ case "$image" in
TRITON=yes
;;
pytorch-linux-focal-py3-clang10-onnx)
ANACONDA_PYTHON_VERSION=3.8
ANACONDA_PYTHON_VERSION=3.9
CLANG_VERSION=10
PROTOBUF=yes
DB=yes
Expand All @@ -245,7 +245,7 @@ case "$image" in
ONNX=yes
;;
pytorch-linux-focal-py3-clang9-android-ndk-r21e)
ANACONDA_PYTHON_VERSION=3.8
ANACONDA_PYTHON_VERSION=3.9
CLANG_VERSION=9
LLVMDEV=yes
PROTOBUF=yes
Expand All @@ -254,8 +254,8 @@ case "$image" in
GRADLE_VERSION=6.8.3
NINJA_VERSION=1.9.0
;;
pytorch-linux-focal-py3.8-clang10)
ANACONDA_PYTHON_VERSION=3.8
pytorch-linux-focal-py3.9-clang10)
ANACONDA_PYTHON_VERSION=3.9
CLANG_VERSION=10
PROTOBUF=yes
DB=yes
Expand All @@ -276,8 +276,8 @@ case "$image" in
CONDA_CMAKE=yes
TRITON=yes
;;
pytorch-linux-focal-py3.8-gcc9)
ANACONDA_PYTHON_VERSION=3.8
pytorch-linux-focal-py3.9-gcc9)
ANACONDA_PYTHON_VERSION=3.9
GCC_VERSION=9
PROTOBUF=yes
DB=yes
Expand All @@ -286,7 +286,7 @@ case "$image" in
TRITON=yes
;;
pytorch-linux-focal-rocm-n-1-py3)
ANACONDA_PYTHON_VERSION=3.8
ANACONDA_PYTHON_VERSION=3.10
GCC_VERSION=9
PROTOBUF=yes
DB=yes
Expand All @@ -297,7 +297,7 @@ case "$image" in
TRITON=yes
;;
pytorch-linux-focal-rocm-n-py3)
ANACONDA_PYTHON_VERSION=3.8
ANACONDA_PYTHON_VERSION=3.10
GCC_VERSION=9
PROTOBUF=yes
DB=yes
Expand All @@ -318,8 +318,8 @@ case "$image" in
CONDA_CMAKE=yes
TRITON=yes
;;
pytorch-linux-jammy-py3.8-gcc11-inductor-benchmarks)
ANACONDA_PYTHON_VERSION=3.8
pytorch-linux-jammy-py3.9-gcc11-inductor-benchmarks)
ANACONDA_PYTHON_VERSION=3.9
GCC_VERSION=11
PROTOBUF=yes
DB=yes
Expand All @@ -330,8 +330,8 @@ case "$image" in
DOCS=yes
INDUCTOR_BENCHMARKS=yes
;;
pytorch-linux-jammy-cuda11.8-cudnn9-py3.8-clang12)
ANACONDA_PYTHON_VERSION=3.8
pytorch-linux-jammy-cuda11.8-cudnn9-py3.9-clang12)
ANACONDA_PYTHON_VERSION=3.9
CUDA_VERSION=11.8
CUDNN_VERSION=9
CLANG_VERSION=12
Expand All @@ -355,8 +355,8 @@ case "$image" in
CONDA_CMAKE=yes
VISION=yes
;;
pytorch-linux-jammy-py3.8-gcc11)
ANACONDA_PYTHON_VERSION=3.8
pytorch-linux-jammy-py3.9-gcc11)
ANACONDA_PYTHON_VERSION=3.9
GCC_VERSION=11
PROTOBUF=yes
DB=yes
Expand Down
4 changes: 2 additions & 2 deletions .ci/docker/centos-rocm/Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -108,10 +108,10 @@ ENV CMAKE_C_COMPILER cc
ENV CMAKE_CXX_COMPILER c++
COPY ./common/install_triton.sh install_triton.sh
COPY ./common/common_utils.sh common_utils.sh
COPY ci_commit_pins/triton-rocm.txt triton-rocm.txt
COPY ci_commit_pins/triton.txt triton.txt
COPY triton_version.txt triton_version.txt
RUN if [ -n "${TRITON}" ]; then bash ./install_triton.sh; fi
RUN rm install_triton.sh common_utils.sh triton-rocm.txt triton_version.txt
RUN rm install_triton.sh common_utils.sh triton.txt triton_version.txt

# Install AOTriton (Early fail)
COPY ./aotriton_version.txt aotriton_version.txt
Expand Down
2 changes: 1 addition & 1 deletion .ci/docker/ci_commit_pins/executorch.txt
Original file line number Diff line number Diff line change
@@ -1 +1 @@
5e9bab8c5956249e75a0f187bf8075df97ca2555
cd1c833b079adb324871dcbbe75b43d42ffc0ade
2 changes: 1 addition & 1 deletion .ci/docker/ci_commit_pins/halide.txt
Original file line number Diff line number Diff line change
@@ -1 +1 @@
340136fec6d3ebc73e7a19eba1663e9b0ba8ab2d
461c12871f336fe6f57b55d6a297f13ef209161b
1 change: 0 additions & 1 deletion .ci/docker/ci_commit_pins/triton-rocm.txt

This file was deleted.

2 changes: 1 addition & 1 deletion .ci/docker/ci_commit_pins/triton-xpu.txt
Original file line number Diff line number Diff line change
@@ -1 +1 @@
1b2f15840e0d70eec50d84c7a0575cb835524def
91b14bf5593cf58a8541f3e6b9125600a867d4ef
2 changes: 1 addition & 1 deletion .ci/docker/ci_commit_pins/triton.txt
Original file line number Diff line number Diff line change
@@ -1 +1 @@
dedb7bdf339a3546896d4820366ca562c586bfa0
5fe38ffd73c2ac6ed6323b554205186696631c6f
4 changes: 2 additions & 2 deletions .ci/docker/common/install_aotriton.sh
Original file line number Diff line number Diff line change
Expand Up @@ -4,12 +4,12 @@ set -ex

source "$(dirname "${BASH_SOURCE[0]}")/common_utils.sh"

TARBALL='aotriton.tar.bz2'
TARBALL='aotriton.tar.gz'
# This read command alwasy returns with exit code 1
read -d "\n" VER MANYLINUX ROCMBASE PINNED_COMMIT SHA256 < aotriton_version.txt || true
ARCH=$(uname -m)
AOTRITON_INSTALL_PREFIX="$1"
AOTRITON_URL="https://github.com/ROCm/aotriton/releases/download/${VER}/aotriton-${VER}-${MANYLINUX}_${ARCH}-${ROCMBASE}-shared.tar.bz2"
AOTRITON_URL="https://github.com/ROCm/aotriton/releases/download/${VER}/aotriton-${VER}-${MANYLINUX}_${ARCH}-${ROCMBASE}-shared.tar.gz"

cd "${AOTRITON_INSTALL_PREFIX}"
# Must use -L to follow redirects
Expand Down
22 changes: 6 additions & 16 deletions .ci/docker/common/install_conda.sh
Original file line number Diff line number Diff line change
Expand Up @@ -5,32 +5,22 @@ set -ex
# Optionally install conda
if [ -n "$ANACONDA_PYTHON_VERSION" ]; then
BASE_URL="https://repo.anaconda.com/miniconda"
CONDA_FILE="Miniconda3-latest-Linux-x86_64.sh"
if [[ $(uname -m) == "aarch64" ]] || [[ "$BUILD_ENVIRONMENT" == *xpu* ]]; then
BASE_URL="https://github.com/conda-forge/miniforge/releases/latest/download"
CONDA_FILE="Miniforge3-Linux-$(uname -m).sh"
fi

MAJOR_PYTHON_VERSION=$(echo "$ANACONDA_PYTHON_VERSION" | cut -d . -f 1)
MINOR_PYTHON_VERSION=$(echo "$ANACONDA_PYTHON_VERSION" | cut -d . -f 2)

if [[ $(uname -m) == "aarch64" ]]; then
BASE_URL="https://github.com/conda-forge/miniforge/releases/latest/download"
case "$MAJOR_PYTHON_VERSION" in
3)
CONDA_FILE="Miniforge3-Linux-aarch64.sh"
;;
*)
echo "Unsupported ANACONDA_PYTHON_VERSION: $ANACONDA_PYTHON_VERSION"
exit 1
;;
esac
else
case "$MAJOR_PYTHON_VERSION" in
3)
CONDA_FILE="Miniconda3-latest-Linux-x86_64.sh"
;;
3);;
*)
echo "Unsupported ANACONDA_PYTHON_VERSION: $ANACONDA_PYTHON_VERSION"
exit 1
;;
esac
fi

mkdir -p /opt/conda
chown jenkins:jenkins /opt/conda
Expand Down
25 changes: 21 additions & 4 deletions .ci/docker/common/install_cpython.sh
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ PYTHON_DOWNLOAD_GITHUB_BRANCH=https://github.com/python/cpython/archive/refs/hea
GET_PIP_URL=https://bootstrap.pypa.io/get-pip.py

# Python versions to be installed in /opt/$VERSION_NO
CPYTHON_VERSIONS=${CPYTHON_VERSIONS:-"3.8.1 3.9.0 3.10.1 3.11.0 3.12.0 3.13.0"}
CPYTHON_VERSIONS=${CPYTHON_VERSIONS:-"3.8.1 3.9.0 3.10.1 3.11.0 3.12.0 3.13.0 3.13.0t"}

function check_var {
if [ -z "$1" ]; then
Expand All @@ -22,6 +22,13 @@ function do_cpython_build {
check_var $py_ver
check_var $py_folder
tar -xzf Python-$py_ver.tgz

local additional_flags=""
if [ "$py_ver" == "3.13.0t" ]; then
additional_flags=" --disable-gil"
mv cpython-3.13/ cpython-3.13t/
fi

pushd $py_folder

local prefix="/opt/_internal/cpython-${py_ver}"
Expand All @@ -37,8 +44,10 @@ function do_cpython_build {
local openssl_flags="--with-openssl=${WITH_OPENSSL} --with-openssl-rpath=auto"
fi



# -Wformat added for https://bugs.python.org/issue17547 on Python 2.6
CFLAGS="-Wformat" ./configure --prefix=${prefix} ${openssl_flags} ${shared_flags} > /dev/null
CFLAGS="-Wformat" ./configure --prefix=${prefix} ${openssl_flags} ${shared_flags} ${additional_flags} > /dev/null

make -j40 > /dev/null
make install > /dev/null
Expand All @@ -58,7 +67,8 @@ function do_cpython_build {
if [ -e ${prefix}/bin/pip3 ] && [ ! -e ${prefix}/bin/pip ]; then
ln -s pip3 ${prefix}/bin/pip
fi
${prefix}/bin/pip install wheel==0.34.2
# install setuptools since python 3.12 is required to use distutils
${prefix}/bin/pip install wheel==0.34.2 setuptools==68.2.2
local abi_tag=$(${prefix}/bin/python -c "from wheel.pep425tags import get_abbr_impl, get_impl_ver, get_abi_tag; print('{0}{1}-{2}'.format(get_abbr_impl(), get_impl_ver(), get_abi_tag()))")
ln -s ${prefix} /opt/python/${abi_tag}
}
Expand All @@ -68,7 +78,14 @@ function build_cpython {
check_var $py_ver
check_var $PYTHON_DOWNLOAD_URL
local py_ver_folder=$py_ver
if [ "$py_ver" = "3.13.0" ]; then

if [ "$py_ver" = "3.13.0t" ]; then
PY_VER_SHORT="3.13"
PYT_VER_SHORT="3.13t"
check_var $PYTHON_DOWNLOAD_GITHUB_BRANCH
wget $PYTHON_DOWNLOAD_GITHUB_BRANCH/$PY_VER_SHORT.tar.gz -O Python-$py_ver.tgz
do_cpython_build $py_ver cpython-$PYT_VER_SHORT
elif [ "$py_ver" = "3.13.0" ]; then
PY_VER_SHORT="3.13"
check_var $PYTHON_DOWNLOAD_GITHUB_BRANCH
wget $PYTHON_DOWNLOAD_GITHUB_BRANCH/$PY_VER_SHORT.tar.gz -O Python-$py_ver.tgz
Expand Down
2 changes: 1 addition & 1 deletion .ci/docker/common/install_cusparselt.sh
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ set -ex
# cuSPARSELt license: https://docs.nvidia.com/cuda/cusparselt/license.html
mkdir tmp_cusparselt && cd tmp_cusparselt

if [[ ${CUDA_VERSION:0:4} =~ ^12\.[2-4]$ ]]; then
if [[ ${CUDA_VERSION:0:4} =~ ^12\.[2-6]$ ]]; then
arch_path='sbsa'
export TARGETARCH=${TARGETARCH:-$(uname -m)}
if [ ${TARGETARCH} = 'amd64' ] || [ "${TARGETARCH}" = 'x86_64' ]; then
Expand Down
9 changes: 4 additions & 5 deletions .ci/docker/common/install_onnx.sh
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ pip_install \
flatbuffers==2.0 \
mock==5.0.1 \
ninja==1.10.2 \
networkx==2.0 \
networkx==2.5 \
numpy==1.24.2

# ONNXRuntime should be installed before installing
Expand All @@ -30,10 +30,9 @@ pip_install \

pip_install coloredlogs packaging

pip_install onnxruntime==1.18
pip_install onnx==1.16.0
# pip_install "onnxscript@git+https://github.com/microsoft/onnxscript@3e869ef8ccf19b5ebd21c10d3e9c267c9a9fa729" --no-deps
pip_install onnxscript==0.1.0.dev20240613 --no-deps
pip_install onnxruntime==1.18.1
pip_install onnx==1.16.2
pip_install onnxscript==0.1.0.dev20240831 --no-deps
# required by onnxscript
pip_install ml_dtypes

Expand Down
5 changes: 1 addition & 4 deletions .ci/docker/common/install_triton.sh
Original file line number Diff line number Diff line change
Expand Up @@ -12,10 +12,7 @@ conda_reinstall() {
as_jenkins conda install -q -n py_$ANACONDA_PYTHON_VERSION -y --force-reinstall $*
}

if [ -n "${ROCM_VERSION}" ]; then
TRITON_REPO="https://github.com/openai/triton"
TRITON_TEXT_FILE="triton-rocm"
elif [ -n "${XPU_VERSION}" ]; then
if [ -n "${XPU_VERSION}" ]; then
TRITON_REPO="https://github.com/intel/intel-xpu-backend-for-triton"
TRITON_TEXT_FILE="triton-xpu"
else
Expand Down
16 changes: 13 additions & 3 deletions .ci/docker/requirements-ci.txt
Original file line number Diff line number Diff line change
Expand Up @@ -30,9 +30,14 @@ dill==0.3.7
#Pinned versions: 0.3.7
#test that import: dynamo/test_replay_record.py test_dataloader.py test_datapipe.py test_serialization.py

expecttest==0.1.6
expecttest==0.2.1
#Description: method for writing tests where test framework auto populates
# the expected output based on previous runs
#Pinned versions: 0.2.1
#test that import:

fbscribelogger==0.1.6
#Description: write to scribe from authenticated jobs on CI
#Pinned versions: 0.1.6
#test that import:

Expand Down Expand Up @@ -85,7 +90,7 @@ librosa>=0.6.2 ; python_version < "3.11"
#Pinned versions:
#test that import:

mypy==1.10.0
mypy==1.11.2
# Pin MyPy version because new errors are likely to appear with each release
#Description: linter
#Pinned versions: 1.10.0
Expand All @@ -104,7 +109,7 @@ networkx==2.8.8
#test that import: run_test.py, test_cpp_extensions_aot.py,test_determination.py

numba==0.49.0 ; python_version < "3.9"
numba==0.54.1 ; python_version == "3.9"
numba==0.55.2 ; python_version == "3.9"
numba==0.55.2 ; python_version == "3.10"
#Description: Just-In-Time Compiler for Numerical Functions
#Pinned versions: 0.54.1, 0.49.0, <=0.49.1
Expand Down Expand Up @@ -332,3 +337,8 @@ onnxscript==0.1.0.dev20240817
#Description: Required by mypy and test_public_bindings.py when checking torch.onnx._internal
#Pinned versions:
#test that import:

parameterized==0.8.1
#Description: Parameterizes unittests, both the tests themselves and the entire testing class
#Pinned versions:
#test that import:
2 changes: 1 addition & 1 deletion .ci/docker/triton_version.txt
Original file line number Diff line number Diff line change
@@ -1 +1 @@
3.0.0
3.1.0
4 changes: 2 additions & 2 deletions .ci/docker/ubuntu-rocm/Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -100,10 +100,10 @@ ARG TRITON
# try to reach out to S3, which docker build runners don't have access
COPY ./common/install_triton.sh install_triton.sh
COPY ./common/common_utils.sh common_utils.sh
COPY ci_commit_pins/triton-rocm.txt triton-rocm.txt
COPY ci_commit_pins/triton.txt triton.txt
COPY triton_version.txt triton_version.txt
RUN if [ -n "${TRITON}" ]; then bash ./install_triton.sh; fi
RUN rm install_triton.sh common_utils.sh triton-rocm.txt triton_version.txt
RUN rm install_triton.sh common_utils.sh triton.txt triton_version.txt

# Install AOTriton
COPY ./aotriton_version.txt aotriton_version.txt
Expand Down
1 change: 1 addition & 0 deletions .ci/docker/ubuntu-xpu/Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,7 @@ RUN bash ./install_docs_reqs.sh && rm install_docs_reqs.sh
ARG ANACONDA_PYTHON_VERSION
ARG CONDA_CMAKE
ARG DOCS
ARG BUILD_ENVIRONMENT
ENV ANACONDA_PYTHON_VERSION=$ANACONDA_PYTHON_VERSION
ENV PATH /opt/conda/envs/py_$ANACONDA_PYTHON_VERSION/bin:/opt/conda/bin:$PATH
ENV DOCS=$DOCS
Expand Down
5 changes: 2 additions & 3 deletions .ci/pytorch/build.sh
Original file line number Diff line number Diff line change
Expand Up @@ -285,9 +285,8 @@ else
if [[ "$BUILD_ENVIRONMENT" != *rocm* &&
"$BUILD_ENVIRONMENT" != *xla* ]]; then
if [[ "$BUILD_ENVIRONMENT" != *py3.8* ]]; then
# Install numpy-2.0 release candidate for builds
# Which should be backward compatible with Numpy-1.X
python -mpip install --pre numpy==2.0.0rc1
# Install numpy-2.0.2 for builds which are backward compatible with 1.X
python -mpip install --pre numpy==2.0.2
fi

WERROR=1 python setup.py clean
Expand Down
Loading
Loading