[Easy][BE]: Enable clang-tidy check for duplicate includes (pytorch#1…

…16193) Adds a clang-tidy check to flag duplicate include files Pull Request resolved: pytorch#116193 Approved by: https://github.com/albanD, https://github.com/malfet
Chao1Han · Dec 21, 2023 · cc2c2c6 · cc2c2c6
1 parent 2dce364
commit cc2c2c6
Show file tree

Hide file tree

Showing 6 changed files with 1 addition and 6 deletions.
diff --git a/.clang-tidy b/.clang-tidy
@@ -53,6 +53,7 @@ modernize-*,
 performance-*,
 readability-container-size-empty,
 readability-delete-null-pointer,
+readability-duplicate-include
 readability-string-compare,
 '
 HeaderFilterRegex: '^(aten/|c10/|torch/).*$'

diff --git a/aten/src/ATen/core/interned_strings.cpp b/aten/src/ATen/core/interned_strings.cpp
@@ -9,7 +9,6 @@
 #include <string>
 #include <c10/util/Exception.h>
 #include <ATen/core/interned_strings_class.h>
-#include <c10/util/Exception.h>
 
 namespace c10 {
 

diff --git a/torch/csrc/Dtype.cpp b/torch/csrc/Dtype.cpp
@@ -11,8 +11,6 @@
 #include <torch/csrc/utils/tensor_types.h>
 #include <cstring>
 
-#include <torch/csrc/Exceptions.h>
-
 PyObject* THPDtype_New(at::ScalarType scalar_type, const std::string& name) {
   HANDLE_TH_ERRORS
   AT_ASSERT(name.length() < DTYPE_NAME_LEN);

diff --git a/torch/csrc/Module.cpp b/torch/csrc/Module.cpp
@@ -87,7 +87,6 @@
 #include <torch/csrc/utils/verbose.h>
 
 #include <ATen/native/transformers/sdp_utils_cpp.h>
-#include <c10/util/Logging.h>
 #include <torch/csrc/profiler/combined_traceback.h>
 #include <sstream>
 #ifdef USE_CUDA

diff --git a/torch/csrc/Size.cpp b/torch/csrc/Size.cpp
@@ -12,7 +12,6 @@
 
 #include <torch/csrc/autograd/python_variable.h>
 #include <torch/csrc/jit/frontend/tracer.h>
-#include <torch/csrc/utils/pybind.h>
 
 struct THPSize {
   PyTupleObject tuple;

diff --git a/torch/csrc/utils/python_dispatch.cpp b/torch/csrc/utils/python_dispatch.cpp
@@ -20,7 +20,6 @@
 #include <c10/util/flat_hash_map.h>
 #include <pybind11/operators.h>
 #include <pybind11/stl.h>
-#include <torch/csrc/jit/python/pybind_utils.h>
 #include <torch/csrc/utils/pybind.h>
 #include <torch/csrc/utils/python_raii.h>