-
-
Notifications
You must be signed in to change notification settings - Fork 306
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: implement partial spec changes for devnet-5 #7229
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## devnet-5 #7229 +/- ##
============================================
- Coverage 48.50% 48.40% -0.10%
============================================
Files 600 602 +2
Lines 40135 40354 +219
Branches 2054 2062 +8
============================================
+ Hits 19468 19534 +66
- Misses 20629 20782 +153
Partials 38 38 |
Performance Report✔️ no performance regression detected Full benchmark results
|
packages/state-transition/src/block/processAttestationPhase0.ts
Outdated
Show resolved
Hide resolved
packages/state-transition/src/block/processAttestationPhase0.ts
Outdated
Show resolved
Hide resolved
packages/state-transition/src/block/processAttestationPhase0.ts
Outdated
Show resolved
Hide resolved
Ignore spec test result for now. We can run spec test altogether in #7246 |
@ensi321 I rebased the branch to drop one commit which somehow got in here from unstable branch |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This PR updates Lodestar with respect to the spec changes in
earliest_exit_epoch
calculation & add tests ethereum/consensus-specs#4001