Skip to content

Memory Wallet Implementation #212

Memory Wallet Implementation

Memory Wallet Implementation #212

Triggered via pull request December 3, 2024 23:01
@ec2ec2
synchronize #1
ec2/memwallet
Status Failure
Total duration 2m 58s
Artifacts

audits.yml

on: pull_request
Vet Rust dependencies
2m 37s
Vet Rust dependencies
Check licenses
46s
Check licenses
Required status checks have passed
0s
Required status checks have passed
Fit to window
Zoom out
Zoom in

Annotations

41 errors and 3 warnings
missing field `key_source` in initializer of `zcash_client_backend::data_api::AccountSource`: zcash_client_memory/src/wallet_write.rs#L1062
error[E0063]: missing field `key_source` in initializer of `zcash_client_backend::data_api::AccountSource` --> zcash_client_memory/src/wallet_write.rs:1062:13 | 1062 | AccountSource::Imported { purpose }, | ^^^^^^^^^^^^^^^^^^^^^^^ missing `key_source`
missing field `key_source` in initializer of `zcash_client_backend::data_api::AccountSource`: zcash_client_memory/src/wallet_write.rs#L88
error[E0063]: missing field `key_source` in initializer of `zcash_client_backend::data_api::AccountSource` --> zcash_client_memory/src/wallet_write.rs:88:17 | 88 | AccountSource::Derived { | ^^^^^^^^^^^^^^^^^^^^^^ missing `key_source`
mismatched types: zcash_client_memory/src/wallet_read.rs#L144
error[E0308]: mismatched types --> zcash_client_memory/src/wallet_read.rs:144:21 | 140 | if seed_matches_derived_account( | ---------------------------- arguments to this function are incorrect ... 144 | account_index, | ^^^^^^^^^^^^^ expected `AccountId`, found `&AccountId` | note: function defined here --> zcash_client_memory/src/wallet_read.rs:752:4 | 752 | fn seed_matches_derived_account<P: consensus::Parameters>( | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ ... 756 | account_index: zip32::AccountId, | ------------------------------- help: consider dereferencing the borrow | 144 | *account_index, | +
pattern does not mention field `key_source`: zcash_client_memory/src/wallet_read.rs#L133
error[E0027]: pattern does not mention field `key_source` --> zcash_client_memory/src/wallet_read.rs:133:20 | 133 | if let AccountSource::Derived { | ____________________^ 134 | | seed_fingerprint, 135 | | account_index, 136 | | } = account.source() | |_____________^ missing field `key_source` | help: include the missing field in the pattern | 135 | account_index, key_source } = account.source() | ~~~~~~~~~~~~~~ help: if you don't care about this missing field, you can explicitly ignore it | 135 | account_index, .. } = account.source() | ~~~~~~
mismatched types: zcash_client_memory/src/wallet_read.rs#L104
error[E0308]: mismatched types --> zcash_client_memory/src/wallet_read.rs:104:21 | 100 | seed_matches_derived_account( | ---------------------------- arguments to this function are incorrect ... 104 | account_index, | ^^^^^^^^^^^^^ expected `AccountId`, found `&AccountId` | note: function defined here --> zcash_client_memory/src/wallet_read.rs:752:4 | 752 | fn seed_matches_derived_account<P: consensus::Parameters>( | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ ... 756 | account_index: zip32::AccountId, | ------------------------------- help: consider dereferencing the borrow | 104 | *account_index, | +
pattern does not mention field `key_source`: zcash_client_memory/src/wallet_read.rs#L95
error[E0027]: pattern does not mention field `key_source` --> zcash_client_memory/src/wallet_read.rs:95:20 | 95 | if let AccountSource::Derived { | ____________________^ 96 | | seed_fingerprint, 97 | | account_index, 98 | | } = account.source() | |_____________^ missing field `key_source` | help: include the missing field in the pattern | 97 | account_index, key_source } = account.source() | ~~~~~~~~~~~~~~ help: if you don't care about this missing field, you can explicitly ignore it | 97 | account_index, .. } = account.source() | ~~~~~~
pattern does not mention field `key_source`: zcash_client_memory/src/wallet_read.rs#L84
error[E0027]: pattern does not mention field `key_source` --> zcash_client_memory/src/wallet_read.rs:84:17 | 84 | AccountSource::Imported { purpose: _ } => None, | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ missing field `key_source` | help: include the missing field in the pattern | 84 | AccountSource::Imported { purpose: _, key_source } => None, | ~~~~~~~~~~~~~~ help: if you don't care about this missing field, you can explicitly ignore it | 84 | AccountSource::Imported { purpose: _, .. } => None, | ~~~~~~
pattern does not mention field `key_source`: zcash_client_memory/src/wallet_read.rs#L74
error[E0027]: pattern does not mention field `key_source` --> zcash_client_memory/src/wallet_read.rs:74:17 | 74 | / AccountSource::Derived { 75 | | seed_fingerprint, 76 | | account_index, 77 | | } => { | |_________________^ missing field `key_source` | help: include the missing field in the pattern | 76 | account_index, key_source } => { | ~~~~~~~~~~~~~~ help: if you don't care about this missing field, you can explicitly ignore it | 76 | account_index, .. } => { | ~~~~~~
mismatched types: zcash_client_memory/src/types/memory_wallet/mod.rs#L477
error[E0308]: mismatched types --> zcash_client_memory/src/types/memory_wallet/mod.rs:477:12 | 477 | Ok(self | _________--_^ | | | | | arguments to this enum variant are incorrect 478 | | .accounts 479 | | .iter() 480 | | .filter_map(|(_, a)| match a.source() { ... | 492 | | }) 493 | | .max()) | |__________________^ expected `Option<AccountId>`, found `Option<&AccountId>` | = note: expected enum `std::option::Option<zip32::AccountId>` found enum `std::option::Option<&zip32::AccountId>` help: the type constructed contains `std::option::Option<&zip32::AccountId>` due to the type of the argument passed --> zcash_client_memory/src/types/memory_wallet/mod.rs:477:9 | 477 | Ok(self | __________^__- | | _________| | || 478 | || .accounts 479 | || .iter() 480 | || .filter_map(|(_, a)| match a.source() { ... || 492 | || }) 493 | || .max()) | ||__________________-^ | |___________________| | this argument influences the type of `Ok` note: tuple variant defined here --> /rustc/aedd173a2c086e558c2b66d3743b344f977621a7/library/core/src/result.rs:506:5 help: use `std::option::Option::copied` to copy the value inside the `std::option::Option` | 493 | .max().copied()) | +++++++++
can't compare `&zip32::fingerprint::SeedFingerprint` with `zip32::fingerprint::SeedFingerprint`: zcash_client_memory/src/types/memory_wallet/mod.rs#L485
error[E0277]: can't compare `&zip32::fingerprint::SeedFingerprint` with `zip32::fingerprint::SeedFingerprint` --> zcash_client_memory/src/types/memory_wallet/mod.rs:485:28 | 485 | if &sf == seed_fingerprint { | ^^ no implementation for `&zip32::fingerprint::SeedFingerprint == zip32::fingerprint::SeedFingerprint` | = help: the trait `std::cmp::PartialEq<zip32::fingerprint::SeedFingerprint>` is not implemented for `&zip32::fingerprint::SeedFingerprint`, which is required by `&&zip32::fingerprint::SeedFingerprint: std::cmp::PartialEq<&zip32::fingerprint::SeedFingerprint>` = note: required for `&&zip32::fingerprint::SeedFingerprint` to implement `std::cmp::PartialEq<&zip32::fingerprint::SeedFingerprint>` help: consider removing the borrow | 485 - if &sf == seed_fingerprint { 485 + if sf == seed_fingerprint { |
pattern does not mention field `key_source`: zcash_client_memory/src/types/memory_wallet/mod.rs#L481
error[E0027]: pattern does not mention field `key_source` --> zcash_client_memory/src/types/memory_wallet/mod.rs:481:17 | 481 | / AccountSource::Derived { 482 | | seed_fingerprint: sf, 483 | | account_index, 484 | | } => { | |_________________^ missing field `key_source` | help: include the missing field in the pattern | 483 | account_index, key_source } => { | ~~~~~~~~~~~~~~ help: if you don't care about this missing field, you can explicitly ignore it | 483 | account_index, .. } => { | ~~~~~~
missing field `key_source` in initializer of `zcash_client_backend::data_api::AccountSource`: zcash_client_memory/src/types/account.rs#L736
error[E0063]: missing field `key_source` in initializer of `zcash_client_backend::data_api::AccountSource` --> zcash_client_memory/src/types/account.rs:736:17 | 736 | AccountSource::Imported { | ^^^^^^^^^^^^^^^^^^^^^^^ missing `key_source`
missing field `key_source` in initializer of `zcash_client_backend::data_api::AccountSource`: zcash_client_memory/src/types/account.rs#L614
error[E0063]: missing field `key_source` in initializer of `zcash_client_backend::data_api::AccountSource` --> zcash_client_memory/src/types/account.rs:614:26 | 614 | 1 => AccountSource::Imported { | ^^^^^^^^^^^^^^^^^^^^^^^ missing `key_source`
missing field `key_source` in initializer of `zcash_client_backend::data_api::AccountSource`: zcash_client_memory/src/types/account.rs#L608
error[E0063]: missing field `key_source` in initializer of `zcash_client_backend::data_api::AccountSource` --> zcash_client_memory/src/types/account.rs:608:26 | 608 | 0 => AccountSource::Derived { | ^^^^^^^^^^^^^^^^^^^^^^ missing `key_source`
pattern does not mention field `key_source`: zcash_client_memory/src/types/account.rs#L567
error[E0027]: pattern does not mention field `key_source` --> zcash_client_memory/src/types/account.rs:567:21 | 567 | AccountSource::Imported { purpose } => match purpose { | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ missing field `key_source` | help: include the missing field in the pattern | 567 | AccountSource::Imported { purpose, key_source } => match purpose { | ~~~~~~~~~~~~~~ help: if you don't care about this missing field, you can explicitly ignore it | 567 | AccountSource::Imported { purpose, .. } => match purpose { | ~~~~~~
missing field `key_source` in initializer of `zcash_client_backend::data_api::AccountSource`: zcash_client_memory/src/wallet_write.rs#L1062
error[E0063]: missing field `key_source` in initializer of `zcash_client_backend::data_api::AccountSource` --> zcash_client_memory/src/wallet_write.rs:1062:13 | 1062 | AccountSource::Imported { purpose }, | ^^^^^^^^^^^^^^^^^^^^^^^ missing `key_source`
method `import_account_ufvk` has 4 parameters but the declaration in trait `zcash_client_backend::data_api::WalletWrite::import_account_ufvk` has 6: zcash_client_memory/src/wallet_write.rs#L1055
error[E0050]: method `import_account_ufvk` has 4 parameters but the declaration in trait `zcash_client_backend::data_api::WalletWrite::import_account_ufvk` has 6 --> zcash_client_memory/src/wallet_write.rs:1055:9 | 1055 | / &mut self, 1056 | | unified_key: &UnifiedFullViewingKey, 1057 | | birthday: &AccountBirthday, 1058 | | purpose: AccountPurpose, | |_______________________________^ expected 6 parameters, found 4 | = note: `import_account_ufvk` from trait: `fn(&mut Self, &str, &zcash_client_backend::keys::UnifiedFullViewingKey, &zcash_client_backend::data_api::AccountBirthday, zcash_client_backend::data_api::AccountPurpose, std::option::Option<&str>) -> std::result::Result<<Self as zcash_client_backend::data_api::WalletRead>::Account, <Self as zcash_client_backend::data_api::WalletRead>::Error>`
method `import_account_hd` has 4 parameters but the declaration in trait `zcash_client_backend::data_api::WalletWrite::import_account_hd` has 6: zcash_client_memory/src/wallet_write.rs#L1043
error[E0050]: method `import_account_hd` has 4 parameters but the declaration in trait `zcash_client_backend::data_api::WalletWrite::import_account_hd` has 6 --> zcash_client_memory/src/wallet_write.rs:1043:9 | 1043 | / &mut self, 1044 | | _seed: &SecretVec<u8>, 1045 | | _account_index: zip32::AccountId, 1046 | | _birthday: &AccountBirthday, | |___________________________________^ expected 6 parameters, found 4 | = note: `import_account_hd` from trait: `fn(&mut Self, &str, &secrecy::Secret<std::vec::Vec<u8>>, zip32::AccountId, &zcash_client_backend::data_api::AccountBirthday, std::option::Option<&str>) -> std::result::Result<(<Self as zcash_client_backend::data_api::WalletRead>::Account, zcash_client_backend::keys::UnifiedSpendingKey), <Self as zcash_client_backend::data_api::WalletRead>::Error>`
method `create_account` has 3 parameters but the declaration in trait `zcash_client_backend::data_api::WalletWrite::create_account` has 5: zcash_client_memory/src/wallet_write.rs#L65
error[E0050]: method `create_account` has 3 parameters but the declaration in trait `zcash_client_backend::data_api::WalletWrite::create_account` has 5 --> zcash_client_memory/src/wallet_write.rs:65:9 | 65 | / &mut self, 66 | | seed: &SecretVec<u8>, 67 | | birthday: &AccountBirthday, | |__________________________________^ expected 5 parameters, found 3 | = note: `create_account` from trait: `fn(&mut Self, &str, &secrecy::Secret<std::vec::Vec<u8>>, &zcash_client_backend::data_api::AccountBirthday, std::option::Option<&str>) -> std::result::Result<(<Self as zcash_client_backend::data_api::WalletRead>::AccountId, zcash_client_backend::keys::UnifiedSpendingKey), <Self as zcash_client_backend::data_api::WalletRead>::Error>`
missing field `key_source` in initializer of `zcash_client_backend::data_api::AccountSource`: zcash_client_memory/src/wallet_write.rs#L88
error[E0063]: missing field `key_source` in initializer of `zcash_client_backend::data_api::AccountSource` --> zcash_client_memory/src/wallet_write.rs:88:17 | 88 | AccountSource::Derived { | ^^^^^^^^^^^^^^^^^^^^^^ missing `key_source`
not all trait items implemented, missing: `name`: zcash_client_memory/src/types/account.rs#L489
error[E0046]: not all trait items implemented, missing: `name` --> zcash_client_memory/src/types/account.rs:489:1 | 489 | impl zcash_client_backend::data_api::Account for Account { | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ missing `name` in implementation | = help: implement the missing item: `fn name(&self) -> std::option::Option<&str> { todo!() }`
method `source` has an incompatible type for trait: zcash_client_memory/src/types/account.rs#L496
error[E0053]: method `source` has an incompatible type for trait --> zcash_client_memory/src/types/account.rs:496:25 | 496 | fn source(&self) -> AccountSource { | ^^^^^^^^^^^^^ | | | expected `&AccountSource`, found `AccountSource` | help: change the output type to match the trait: `&zcash_client_backend::data_api::AccountSource` | = note: expected signature `fn(&types::account::Account) -> &zcash_client_backend::data_api::AccountSource` found signature `fn(&types::account::Account) -> zcash_client_backend::data_api::AccountSource`
mismatched types: zcash_client_memory/src/wallet_read.rs#L144
error[E0308]: mismatched types --> zcash_client_memory/src/wallet_read.rs:144:21 | 140 | if seed_matches_derived_account( | ---------------------------- arguments to this function are incorrect ... 144 | account_index, | ^^^^^^^^^^^^^ expected `AccountId`, found `&AccountId` | note: function defined here --> zcash_client_memory/src/wallet_read.rs:752:4 | 752 | fn seed_matches_derived_account<P: consensus::Parameters>( | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ ... 756 | account_index: zip32::AccountId, | ------------------------------- help: consider dereferencing the borrow | 144 | *account_index, | +
pattern does not mention field `key_source`: zcash_client_memory/src/wallet_read.rs#L133
error[E0027]: pattern does not mention field `key_source` --> zcash_client_memory/src/wallet_read.rs:133:20 | 133 | if let AccountSource::Derived { | ____________________^ 134 | | seed_fingerprint, 135 | | account_index, 136 | | } = account.source() | |_____________^ missing field `key_source` | help: include the missing field in the pattern | 135 | account_index, key_source } = account.source() | ~~~~~~~~~~~~~~ help: if you don't care about this missing field, you can explicitly ignore it | 135 | account_index, .. } = account.source() | ~~~~~~
mismatched types: zcash_client_memory/src/wallet_read.rs#L104
error[E0308]: mismatched types --> zcash_client_memory/src/wallet_read.rs:104:21 | 100 | seed_matches_derived_account( | ---------------------------- arguments to this function are incorrect ... 104 | account_index, | ^^^^^^^^^^^^^ expected `AccountId`, found `&AccountId` | note: function defined here --> zcash_client_memory/src/wallet_read.rs:752:4 | 752 | fn seed_matches_derived_account<P: consensus::Parameters>( | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ ... 756 | account_index: zip32::AccountId, | ------------------------------- help: consider dereferencing the borrow | 104 | *account_index, | +
pattern does not mention field `key_source`: zcash_client_memory/src/wallet_read.rs#L95
error[E0027]: pattern does not mention field `key_source` --> zcash_client_memory/src/wallet_read.rs:95:20 | 95 | if let AccountSource::Derived { | ____________________^ 96 | | seed_fingerprint, 97 | | account_index, 98 | | } = account.source() | |_____________^ missing field `key_source` | help: include the missing field in the pattern | 97 | account_index, key_source } = account.source() | ~~~~~~~~~~~~~~ help: if you don't care about this missing field, you can explicitly ignore it | 97 | account_index, .. } = account.source() | ~~~~~~
pattern does not mention field `key_source`: zcash_client_memory/src/wallet_read.rs#L84
error[E0027]: pattern does not mention field `key_source` --> zcash_client_memory/src/wallet_read.rs:84:17 | 84 | AccountSource::Imported { purpose: _ } => None, | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ missing field `key_source` | help: include the missing field in the pattern | 84 | AccountSource::Imported { purpose: _, key_source } => None, | ~~~~~~~~~~~~~~ help: if you don't care about this missing field, you can explicitly ignore it | 84 | AccountSource::Imported { purpose: _, .. } => None, | ~~~~~~
pattern does not mention field `key_source`: zcash_client_memory/src/wallet_read.rs#L74
error[E0027]: pattern does not mention field `key_source` --> zcash_client_memory/src/wallet_read.rs:74:17 | 74 | / AccountSource::Derived { 75 | | seed_fingerprint, 76 | | account_index, 77 | | } => { | |_________________^ missing field `key_source` | help: include the missing field in the pattern | 76 | account_index, key_source } => { | ~~~~~~~~~~~~~~ help: if you don't care about this missing field, you can explicitly ignore it | 76 | account_index, .. } => { | ~~~~~~
mismatched types: zcash_client_memory/src/types/memory_wallet/mod.rs#L477
error[E0308]: mismatched types --> zcash_client_memory/src/types/memory_wallet/mod.rs:477:12 | 477 | Ok(self | _________--_^ | | | | | arguments to this enum variant are incorrect 478 | | .accounts 479 | | .iter() 480 | | .filter_map(|(_, a)| match a.source() { ... | 492 | | }) 493 | | .max()) | |__________________^ expected `Option<AccountId>`, found `Option<&AccountId>` | = note: expected enum `std::option::Option<zip32::AccountId>` found enum `std::option::Option<&zip32::AccountId>` help: the type constructed contains `std::option::Option<&zip32::AccountId>` due to the type of the argument passed --> zcash_client_memory/src/types/memory_wallet/mod.rs:477:9 | 477 | Ok(self | __________^__- | | _________| | || 478 | || .accounts 479 | || .iter() 480 | || .filter_map(|(_, a)| match a.source() { ... || 492 | || }) 493 | || .max()) | ||__________________-^ | |___________________| | this argument influences the type of `Ok` note: tuple variant defined here --> /rustc/aedd173a2c086e558c2b66d3743b344f977621a7/library/core/src/result.rs:506:5 help: use `std::option::Option::copied` to copy the value inside the `std::option::Option` | 493 | .max().copied()) | +++++++++
can't compare `&zip32::fingerprint::SeedFingerprint` with `zip32::fingerprint::SeedFingerprint`: zcash_client_memory/src/types/memory_wallet/mod.rs#L485
error[E0277]: can't compare `&zip32::fingerprint::SeedFingerprint` with `zip32::fingerprint::SeedFingerprint` --> zcash_client_memory/src/types/memory_wallet/mod.rs:485:28 | 485 | if &sf == seed_fingerprint { | ^^ no implementation for `&zip32::fingerprint::SeedFingerprint == zip32::fingerprint::SeedFingerprint` | = help: the trait `std::cmp::PartialEq<zip32::fingerprint::SeedFingerprint>` is not implemented for `&zip32::fingerprint::SeedFingerprint`, which is required by `&&zip32::fingerprint::SeedFingerprint: std::cmp::PartialEq<&zip32::fingerprint::SeedFingerprint>` = note: required for `&&zip32::fingerprint::SeedFingerprint` to implement `std::cmp::PartialEq<&zip32::fingerprint::SeedFingerprint>` help: consider removing the borrow | 485 - if &sf == seed_fingerprint { 485 + if sf == seed_fingerprint { |
pattern does not mention field `key_source`: zcash_client_memory/src/types/memory_wallet/mod.rs#L481
error[E0027]: pattern does not mention field `key_source` --> zcash_client_memory/src/types/memory_wallet/mod.rs:481:17 | 481 | / AccountSource::Derived { 482 | | seed_fingerprint: sf, 483 | | account_index, 484 | | } => { | |_________________^ missing field `key_source` | help: include the missing field in the pattern | 483 | account_index, key_source } => { | ~~~~~~~~~~~~~~ help: if you don't care about this missing field, you can explicitly ignore it | 483 | account_index, .. } => { | ~~~~~~
missing field `key_source` in initializer of `zcash_client_backend::data_api::AccountSource`: zcash_client_memory/src/types/account.rs#L614
error[E0063]: missing field `key_source` in initializer of `zcash_client_backend::data_api::AccountSource` --> zcash_client_memory/src/types/account.rs:614:26 | 614 | 1 => AccountSource::Imported { | ^^^^^^^^^^^^^^^^^^^^^^^ missing `key_source`
missing field `key_source` in initializer of `zcash_client_backend::data_api::AccountSource`: zcash_client_memory/src/types/account.rs#L608
error[E0063]: missing field `key_source` in initializer of `zcash_client_backend::data_api::AccountSource` --> zcash_client_memory/src/types/account.rs:608:26 | 608 | 0 => AccountSource::Derived { | ^^^^^^^^^^^^^^^^^^^^^^ missing `key_source`
pattern does not mention field `key_source`: zcash_client_memory/src/types/account.rs#L567
error[E0027]: pattern does not mention field `key_source` --> zcash_client_memory/src/types/account.rs:567:21 | 567 | AccountSource::Imported { purpose } => match purpose { | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ missing field `key_source` | help: include the missing field in the pattern | 567 | AccountSource::Imported { purpose, key_source } => match purpose { | ~~~~~~~~~~~~~~ help: if you don't care about this missing field, you can explicitly ignore it | 567 | AccountSource::Imported { purpose, .. } => match purpose { | ~~~~~~
method `import_account_ufvk` has 4 parameters but the declaration in trait `zcash_client_backend::data_api::WalletWrite::import_account_ufvk` has 6: zcash_client_memory/src/wallet_write.rs#L1055
error[E0050]: method `import_account_ufvk` has 4 parameters but the declaration in trait `zcash_client_backend::data_api::WalletWrite::import_account_ufvk` has 6 --> zcash_client_memory/src/wallet_write.rs:1055:9 | 1055 | / &mut self, 1056 | | unified_key: &UnifiedFullViewingKey, 1057 | | birthday: &AccountBirthday, 1058 | | purpose: AccountPurpose, | |_______________________________^ expected 6 parameters, found 4 | = note: `import_account_ufvk` from trait: `fn(&mut Self, &str, &zcash_client_backend::keys::UnifiedFullViewingKey, &zcash_client_backend::data_api::AccountBirthday, zcash_client_backend::data_api::AccountPurpose, std::option::Option<&str>) -> std::result::Result<<Self as zcash_client_backend::data_api::WalletRead>::Account, <Self as zcash_client_backend::data_api::WalletRead>::Error>`
method `import_account_hd` has 4 parameters but the declaration in trait `zcash_client_backend::data_api::WalletWrite::import_account_hd` has 6: zcash_client_memory/src/wallet_write.rs#L1043
error[E0050]: method `import_account_hd` has 4 parameters but the declaration in trait `zcash_client_backend::data_api::WalletWrite::import_account_hd` has 6 --> zcash_client_memory/src/wallet_write.rs:1043:9 | 1043 | / &mut self, 1044 | | _seed: &SecretVec<u8>, 1045 | | _account_index: zip32::AccountId, 1046 | | _birthday: &AccountBirthday, | |___________________________________^ expected 6 parameters, found 4 | = note: `import_account_hd` from trait: `fn(&mut Self, &str, &secrecy::Secret<std::vec::Vec<u8>>, zip32::AccountId, &zcash_client_backend::data_api::AccountBirthday, std::option::Option<&str>) -> std::result::Result<(<Self as zcash_client_backend::data_api::WalletRead>::Account, zcash_client_backend::keys::UnifiedSpendingKey), <Self as zcash_client_backend::data_api::WalletRead>::Error>`
method `create_account` has 3 parameters but the declaration in trait `zcash_client_backend::data_api::WalletWrite::create_account` has 5: zcash_client_memory/src/wallet_write.rs#L65
error[E0050]: method `create_account` has 3 parameters but the declaration in trait `zcash_client_backend::data_api::WalletWrite::create_account` has 5 --> zcash_client_memory/src/wallet_write.rs:65:9 | 65 | / &mut self, 66 | | seed: &SecretVec<u8>, 67 | | birthday: &AccountBirthday, | |__________________________________^ expected 5 parameters, found 3 | = note: `create_account` from trait: `fn(&mut Self, &str, &secrecy::Secret<std::vec::Vec<u8>>, &zcash_client_backend::data_api::AccountBirthday, std::option::Option<&str>) -> std::result::Result<(<Self as zcash_client_backend::data_api::WalletRead>::AccountId, zcash_client_backend::keys::UnifiedSpendingKey), <Self as zcash_client_backend::data_api::WalletRead>::Error>`
not all trait items implemented, missing: `name`: zcash_client_memory/src/types/account.rs#L489
error[E0046]: not all trait items implemented, missing: `name` --> zcash_client_memory/src/types/account.rs:489:1 | 489 | impl zcash_client_backend::data_api::Account for Account { | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ missing `name` in implementation | = help: implement the missing item: `fn name(&self) -> std::option::Option<&str> { todo!() }`
method `source` has an incompatible type for trait: zcash_client_memory/src/types/account.rs#L496
error[E0053]: method `source` has an incompatible type for trait --> zcash_client_memory/src/types/account.rs:496:25 | 496 | fn source(&self) -> AccountSource { | ^^^^^^^^^^^^^ | | | expected `&AccountSource`, found `AccountSource` | help: change the output type to match the trait: `&zcash_client_backend::data_api::AccountSource` | = note: expected signature `fn(&types::account::Account) -> &zcash_client_backend::data_api::AccountSource` found signature `fn(&types::account::Account) -> zcash_client_backend::data_api::AccountSource`
Vet Rust dependencies
Process completed with exit code 255.
Required status checks have passed
Process completed with exit code 1.
Check licenses
ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636
Vet Rust dependencies
ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636
Required status checks have passed
ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636