Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix snapshot upload escapes bash #316

Merged
merged 1 commit into from
Oct 12, 2023
Merged

Conversation

LesnyRumcajs
Copy link
Member

@LesnyRumcajs LesnyRumcajs commented Oct 12, 2023

Summary of changes
Changes introduced in this pull request:

Reference issue to close (if applicable)

Closes

Other information and links

@LesnyRumcajs LesnyRumcajs force-pushed the fix-snapshot-upload-bash branch from dd1dd73 to a88f0ad Compare October 12, 2023 12:27
@LesnyRumcajs LesnyRumcajs marked this pull request as ready for review October 12, 2023 12:44
@LesnyRumcajs LesnyRumcajs requested a review from a team as a code owner October 12, 2023 12:44
@LesnyRumcajs LesnyRumcajs requested review from lemmih and hanabi1224 and removed request for a team October 12, 2023 12:44
@github-actions
Copy link

Forest: Snapshot Service Infrastructure Plan: success

Show Plan
module.daily_snapshot.data.external.sources_tar: Reading...
module.daily_snapshot.data.local_file.init: Reading...
module.daily_snapshot.data.local_file.init: Read complete after 0s [id=4ac94881cf28678fd719534880558c2125ca2ec7]
module.daily_snapshot.data.external.sources_tar: Read complete after 0s [id=-]
module.daily_snapshot.data.local_file.sources: Reading...
module.daily_snapshot.data.digitalocean_project.forest_project: Reading...
module.daily_snapshot.data.digitalocean_ssh_keys.keys: Reading...
module.daily_snapshot.data.local_file.sources: Read complete after 0s [id=556b55499f74e4d52727e5317d283a0f028cef95]
module.daily_snapshot.data.digitalocean_ssh_keys.keys: Read complete after 0s [id=ssh_keys/14512061520513425405]
module.daily_snapshot.digitalocean_droplet.forest: Refreshing state... [id=379326355]
module.daily_snapshot.digitalocean_firewall.forest-firewall: Refreshing state... [id=a1d511b7-ef26-4f69-8cc4-69f6d75c0522]
module.daily_snapshot.data.digitalocean_project.forest_project: Read complete after 2s [id=da5e6601-7fd9-4d02-951e-390f7feb3411]
module.daily_snapshot.digitalocean_project_resources.connect_forest_project: Refreshing state... [id=da5e6601-7fd9-4d02-951e-390f7feb3411]

Terraform used the selected providers to generate the following execution
plan. Resource actions are indicated with the following symbols:
  ~ update in-place
-/+ destroy and then create replacement

Terraform will perform the following actions:

  # module.daily_snapshot.digitalocean_droplet.forest must be replaced
-/+ resource "digitalocean_droplet" "forest" {
      ~ created_at           = "2023-10-12T10:40:08Z" -> (known after apply)
      ~ disk                 = 200 -> (known after apply)
      ~ id                   = "379326355" -> (known after apply)
      ~ ipv4_address         = "134.209.237.254" -> (known after apply)
      ~ ipv4_address_private = "10.135.0.4" -> (known after apply)
      + ipv6_address         = (known after apply)
      ~ locked               = false -> (known after apply)
      ~ memory               = 16384 -> (known after apply)
        name                 = "forest-snapshot"
      ~ price_hourly         = 0.125 -> (known after apply)
      ~ price_monthly        = 84 -> (known after apply)
      ~ private_networking   = true -> (known after apply)
      ~ status               = "active" -> (known after apply)
        tags                 = [
            "iac",
        ]
      ~ urn                  = "do:droplet:379326355" -> (known after apply)
      ~ user_data            = "8f60d91b4b58afe29175d0ae7238ffe7cbbe285d" -> "661618501ccb69e3f9fb67a4a4f885c6fb1c9724" # forces replacement
      ~ vcpus                = 4 -> (known after apply)
      ~ volume_ids           = [] -> (known after apply)
      ~ vpc_uuid             = "46a525ac-fd37-47ea-bb10-95c1db0055f7" -> (known after apply)
        # (9 unchanged attributes hidden)
    }

  # module.daily_snapshot.digitalocean_firewall.forest-firewall will be updated in-place
  ~ resource "digitalocean_firewall" "forest-firewall" {
      ~ droplet_ids     = [
          - 379326355,
        ] -> (known after apply)
        id              = "a1d511b7-ef26-4f69-8cc4-69f6d75c0522"
        name            = "forest-snapshot"
        tags            = []
        # (3 unchanged attributes hidden)

        # (6 unchanged blocks hidden)
    }

  # module.daily_snapshot.digitalocean_project_resources.connect_forest_project will be updated in-place
  ~ resource "digitalocean_project_resources" "connect_forest_project" {
        id        = "da5e6601-7fd9-4d02-951e-390f7feb3411"
      ~ resources = [
          - "do:droplet:379326355",
        ] -> (known after apply)
        # (1 unchanged attribute hidden)
    }

Plan: 1 to add, 2 to change, 1 to destroy.

Changes to Outputs:
  ~ ip = [
      - [
          - "134.209.237.254",
        ],
      + [
          + (known after apply),
        ],
    ]

─────────────────────────────────────────────────────────────────────────────

Saved the plan to: tfplan

To perform exactly these actions, run the following command to apply:
    terraform apply "tfplan"

@LesnyRumcajs LesnyRumcajs enabled auto-merge (squash) October 12, 2023 12:47
@LesnyRumcajs LesnyRumcajs merged commit 3181d25 into main Oct 12, 2023
8 checks passed
@LesnyRumcajs LesnyRumcajs deleted the fix-snapshot-upload-bash branch January 22, 2024 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants