Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: MVC faucet first blood #95

Merged
merged 2 commits into from
Dec 13, 2024
Merged

chore: MVC faucet first blood #95

merged 2 commits into from
Dec 13, 2024

Conversation

LesnyRumcajs
Copy link
Member

@LesnyRumcajs LesnyRumcajs commented Dec 12, 2024

Summary of changes

Changes introduced in this pull request:

  • added some docs on the local environment + required bypass with rate limiter,
  • separated the faucet into a rough Model-View-Controller - more work is needed, but my holidays are calling me 🎅
  • there were no changes in the faucet logic itself

Reference issue to close (if applicable)

Closes

Other information and links

Change checklist

  • I have performed a self-review of my own code,
  • I have made corresponding changes to the documentation. All new code
    adheres to the team's
    documentation standards,
  • I have added tests that prove my fix is effective or that my feature works
    (if possible),

@LesnyRumcajs LesnyRumcajs marked this pull request as ready for review December 12, 2024 18:49
@LesnyRumcajs LesnyRumcajs requested a review from a team as a code owner December 12, 2024 18:49
@LesnyRumcajs LesnyRumcajs mentioned this pull request Dec 13, 2024
1 task
@LesnyRumcajs LesnyRumcajs added this pull request to the merge queue Dec 13, 2024
Merged via the queue into main with commit 2d8b387 Dec 13, 2024
5 checks passed
@LesnyRumcajs LesnyRumcajs deleted the mvc-faucet branch December 13, 2024 08:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants