Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add GH template boilerplate #43

Merged
merged 4 commits into from
Oct 8, 2024
Merged

Conversation

LesnyRumcajs
Copy link
Member

@LesnyRumcajs LesnyRumcajs commented Oct 4, 2024

Changes:

  • added some boilerplate to make this repo more of a first-class citizen,
  • added markdown formatter to the CI, fixed offenses,
  • generic ignore file
  • moved some README files to API given they don't give much description and are auto-generated.

@LesnyRumcajs LesnyRumcajs marked this pull request as draft October 4, 2024 12:51
@LesnyRumcajs LesnyRumcajs marked this pull request as ready for review October 4, 2024 13:00
@LesnyRumcajs LesnyRumcajs marked this pull request as draft October 4, 2024 13:00
@LesnyRumcajs
Copy link
Member Author

Oh no, seems I'll need to do some shuffling and ignoring. I'll do it later today.

@@ -744,7 +744,7 @@ mod harness {

#[test]
fn doc() {
expect_test::expect_file!["../README.md"].assert_eq(&cna_util::markdown(
expect_test::expect_file!["../API.md"].assert_eq(&cna_util::markdown(
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Moved to files that would more likely be understood as auto-generated (and it's easier to put it to prettify)

@LesnyRumcajs LesnyRumcajs marked this pull request as ready for review October 4, 2024 14:53
Copy link
Member

@ansermino ansermino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update issue template naming as per ChainSafe/forest#4846

.github/ISSUE_TEMPLATE/task.md Outdated Show resolved Hide resolved
.github/ISSUE_TEMPLATE/epic.md Outdated Show resolved Hide resolved
@LesnyRumcajs LesnyRumcajs requested a review from ansermino October 4, 2024 19:30
@LesnyRumcajs LesnyRumcajs merged commit c329486 into main Oct 8, 2024
6 checks passed
@LesnyRumcajs LesnyRumcajs deleted the add-gh-template-boilerplate branch October 8, 2024 08:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants