Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Makes our Wallet generic over the backing wallet db #19

Merged
merged 5 commits into from
Sep 16, 2024
Merged

Makes our Wallet generic over the backing wallet db #19

merged 5 commits into from
Sep 16, 2024

Conversation

ec2
Copy link
Member

@ec2 ec2 commented Sep 13, 2024

Changes

  • Wallet generic over the backing wallet db
  • Test for sqlite

just test-sqlite

Tests

Issues

@ec2 ec2 requested a review from willemolding September 13, 2024 21:45
willemolding
willemolding approved these changes Sep 16, 2024
View reviewed changes
Copy link
Contributor

@willemolding willemolding left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Possible suggestion is to move any tests we are using just as scripts to be examples instead so we can re-enable tests in CI. Other than that awesome!

@ec2 ec2 merged commit dae657e into main Sep 16, 2024
3 checks passed
@ec2 ec2 deleted the ec2/wallet-compat branch September 16, 2024 16:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@willemolding willemolding willemolding approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ec2 @willemolding