Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix box intersection logic #2

Open
wants to merge 1 commit into
base: chebi-box
Choose a base branch
from
Open

Fix box intersection logic #2

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
31 changes: 12 additions & 19 deletions chebai/models/box_eval.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,34 +2,27 @@

n = len(boxes)
containment_matrix = np.zeros((n, n), dtype=bool)
threshold = 0.99

for i in range(n):
for j in range(n):
if i != j:
box1 = boxes[i]
box2 = boxes[j]

min_corners_box_1 = np.minimum(box1[0], box1[1])
max_corners_box_1 = np.maximum(box1[0], box1[1])
min_corners_box_1 = np.min(box1, axis=-2)
max_corners_box_1 = np.max(box1, axis=-2)

min_corners_box_2 = np.minimum(box2[0], box2[1])
max_corners_box_2 = np.maximum(box2[0], box2[1])
vol_box_1 = np.prod(max_corners_box_1 - min_corners_box_1)

dim = len(min_corners_box_1)
min_corners_box_2 = np.min(box2, axis=-2)
max_corners_box_2 = np.max(box2, axis=-2)

membership_per_dim = []
for d in range(dim):
a = max(min_corners_box_1[d], min_corners_box_2[d])
b = min(max_corners_box_1[d], max_corners_box_2[d])
intersection = (a <= b) * (b - a)
size_of_a = min_corners_box_1[d] + max_corners_box_1[d]
a = np.maximum(min_corners_box_1, min_corners_box_2) # right face of intersection
b = np.minimum(max_corners_box_1, max_corners_box_2) # left face of intersection

# if box_1 is not contained in box_2, then is_contained is zero
intersection_per_dim = (a <= b) * (b - a)
vol_intersection = np.prod(intersection_per_dim)
box_1_is_contained_in_box_2 = vol_intersection / vol_box_1

is_contained = abs(intersection / size_of_a)
membership_per_dim.append(1 if is_contained else 0)


count = sum(1 for item in membership_per_dim if item == 1)
box_1_is_contained_in_box_2 = (count == 10)
containment_matrix[i][j] = box_1_is_contained_in_box_2
containment_matrix[i][j] = box_1_is_contained_in_box_2 > threshold
Loading