-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
EXT_structural_metadata
- parent
class
#70
base: 3d-tiles-next
Are you sure you want to change the base?
Conversation
It's difficult to foresee all implications of this change. Some thoughts: The first part is a breaking change for any existing data that uses the per-object metadata that originally pointed to the property table row. I think that this was not actively or widely used, so the impact might be minimal. In terms of alleviating the possible impact, one could consider different options. In theory, just on a "brainstorming" level, the new structure could "emulate" the old one: Given a data set that defines a node with the extension object...
one could add a new class to the schema, say
The client application would have to be adjusted to handle this. I.e. a possibly existing function like
But again: This is just brainstorming about how existing data could be "upgraded" to the new structure. The additional support for a For example, looking at things like the existing
it was trivial to just throw that It may also require further differentiation for the properties: The When looking at things like
And, more broadly: The |
I think it should, though I'm not sure if it can be done without adding a new extension. |
283f778
to
6946e4a
Compare
I moved the JSON encoding change to its own PR: #71 |
EXT_structural_metadata
updatesEXT_structural_metadata
- parent
class
parent
class that allows for class hierarchies, with some restrictions like no duplicate property IDs and no cyclical inheritance@javagl would you mind taking a look?