-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature] Επιλογή σταθμού σε περισσότερες θέσεις από 9 #113
base: stable
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It was originally supposed to be a "quick start" feature, which explains the 1-9 implementation. Nevertheless, I am totally in favor of such a change, as long as it is working correctly. 👍🏼
+([1-9]))
does not take zeros into account, so shelldio 10
will lead to "wrong selection" response.
By the way, we also need to make sure that extended glob (shopt -s extglob
) is available on all platforms, including different Linux flavors and macOS.
@@ -301,7 +304,7 @@ self_update() { | |||
|
|||
while [ "$1" != "" ]; do | |||
case $1 in | |||
[1-9]) | |||
+([1-9])) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What about 10
, 20
, 30
etc?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Στην δοκιμή μου, έβαλα 15 αγαπημένα. έτρεξα shelldio 14
και έβγαλε Λάθος επιλογή
Δοκιμές:
Άρα η λύση που προτείνει ο @kyriakosschwarz δουλεύει μια χαρά αρκεί να μην έχεις αγαπημένη λίστα. Οπότε δεν μπορεί να γίνει ακόμα merge μέχρι να γίνει η απαραίτητη διόρθωση. |
The integer shell parameter now can be arbitrarily large. Previously 1-9.