Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DPEDE-3079] Add visual tests to copy text component #1450

Conversation

xft-dev
Copy link
Contributor

@xft-dev xft-dev commented Dec 16, 2024

https://lumen.atlassian.net/browse/DPEDE-3079

Test it with https://github.com/CenturyLink/chi-custom-elements/pull/58

Problem: The component had display block and break a line. See image:
image

@lumen-jenkins-prod
Copy link

The CI pipeline did not run successfully in https://jenkinsprod.corp.intranet:8443/job/UX-CHI/job/Productive/job/Chi/job/PR-1450/1/. ❌

@@ -0,0 +1,26 @@
---
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shoudn't that file contain HTML representation of this component ?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah!! good catch

---
title: Copy Text
---
script(type='module' src='../../js/ce/ux-chi-ce/ux-chi-ce.esm.js')
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
script(type='module' src='../../js/ce/ux-chi-ce/ux-chi-ce.esm.js')

@lumen-jenkins-prod
Copy link

The CI pipeline did not run successfully in https://jenkinsprod.corp.intranet:8443/job/UX-CHI/job/Productive/job/Chi/job/PR-1450/2/. ❌

@lumen-jenkins-prod
Copy link

The CI pipeline did not run successfully in https://jenkinsprod.corp.intranet:8443/job/UX-CHI/job/Productive/job/Chi/job/PR-1450/3/. ❌

@lumen-jenkins-prod
Copy link

The CI pipeline did not run successfully in https://jenkinsprod.corp.intranet:8443/job/UX-CHI/job/Productive/job/Chi/job/PR-1450/5/. ❌

@ASanchLumen ASanchLumen force-pushed the feature/DPEDE-3079-add-visual-tests-to-copy-text branch from ad398a8 to c26d59e Compare December 17, 2024 15:40
@lumen-jenkins-prod
Copy link

The CI pipeline did not run successfully in https://jenkinsprod.corp.intranet:8443/job/UX-CHI/job/Productive/job/Chi/job/PR-1450/6/. ❌

@ASanchLumen
Copy link
Contributor

Needs to be updated with master to take the visual tests for date-picker

@lumen-jenkins-prod
Copy link

The CI pipeline did not run successfully in https://jenkinsprod.corp.intranet:8443/job/UX-CHI/job/Productive/job/Chi/job/PR-1450/8/. ❌

Copy link
Contributor

@josecarlosgonzalezv josecarlosgonzalezv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs to be rebased with the latests changes on master.
The fix is currently available.

@xft-dev xft-dev force-pushed the feature/DPEDE-3079-add-visual-tests-to-copy-text branch from 39a88f0 to c0bf27d Compare December 23, 2024 10:28
@lumen-jenkins-prod
Copy link

The CI pipeline did not run successfully in https://jenkinsprod.corp.intranet:8443/job/UX-CHI/job/Productive/job/Chi/job/PR-1450/9/. ❌

@ASanchLumen
Copy link
Contributor

ASanchLumen commented Dec 23, 2024

Reopened in new PR #1463

@lumen-jenkins-prod
Copy link

Removed the Kubernetes allocated resources

4 similar comments
@lumen-jenkins-prod
Copy link

Removed the Kubernetes allocated resources

@lumen-jenkins-prod
Copy link

Removed the Kubernetes allocated resources

@lumen-jenkins-prod
Copy link

Removed the Kubernetes allocated resources

@lumen-jenkins-prod
Copy link

Removed the Kubernetes allocated resources

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants