-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DPEDE-3079] Add visual tests to copy text component #1450
[DPEDE-3079] Add visual tests to copy text component #1450
Conversation
The CI pipeline did not run successfully in https://jenkinsprod.corp.intranet:8443/job/UX-CHI/job/Productive/job/Chi/job/PR-1450/1/. ❌ |
@@ -0,0 +1,26 @@ | |||
--- |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shoudn't that file contain HTML representation of this component ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah!! good catch
test/chi/components/copy-text.pug
Outdated
--- | ||
title: Copy Text | ||
--- | ||
script(type='module' src='../../js/ce/ux-chi-ce/ux-chi-ce.esm.js') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
script(type='module' src='../../js/ce/ux-chi-ce/ux-chi-ce.esm.js') |
The CI pipeline did not run successfully in https://jenkinsprod.corp.intranet:8443/job/UX-CHI/job/Productive/job/Chi/job/PR-1450/2/. ❌ |
The CI pipeline did not run successfully in https://jenkinsprod.corp.intranet:8443/job/UX-CHI/job/Productive/job/Chi/job/PR-1450/3/. ❌ |
The CI pipeline did not run successfully in https://jenkinsprod.corp.intranet:8443/job/UX-CHI/job/Productive/job/Chi/job/PR-1450/5/. ❌ |
ad398a8
to
c26d59e
Compare
The CI pipeline did not run successfully in https://jenkinsprod.corp.intranet:8443/job/UX-CHI/job/Productive/job/Chi/job/PR-1450/6/. ❌ |
Needs to be updated with master to take the visual tests for date-picker |
The CI pipeline did not run successfully in https://jenkinsprod.corp.intranet:8443/job/UX-CHI/job/Productive/job/Chi/job/PR-1450/8/. ❌ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This needs to be rebased with the latests changes on master
.
The fix is currently available.
* [DPEDE-2934] Create picker visual tests * [DPEDE-2934] Update lib with picker wc
39a88f0
to
c0bf27d
Compare
The CI pipeline did not run successfully in https://jenkinsprod.corp.intranet:8443/job/UX-CHI/job/Productive/job/Chi/job/PR-1450/9/. ❌ |
Reopened in new PR #1463 |
Removed the Kubernetes allocated resources |
4 similar comments
Removed the Kubernetes allocated resources |
Removed the Kubernetes allocated resources |
Removed the Kubernetes allocated resources |
Removed the Kubernetes allocated resources |
https://lumen.atlassian.net/browse/DPEDE-3079
Test it with https://github.com/CenturyLink/chi-custom-elements/pull/58
Problem: The component had display block and break a line. See image: