Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

initial commit for claude-light #86

Merged
merged 2 commits into from
Oct 9, 2024
Merged

Conversation

jkitchin
Copy link
Contributor

@jkitchin jkitchin commented Oct 9, 2024

Summary

This adds a small example ALab that uses https://claude-light.cheme.cmu.edu as a remote instrument.

@jkitchin jkitchin changed the title initial commit for clade-light initial commit for claude-light Oct 9, 2024
@idocx
Copy link
Member

idocx commented Oct 9, 2024

Hi John! Thank you for creating the pull request! It seems there are some failed format checking. Do you mind remove the unused imports in devices/claude.py and tasks/claude.py ? If you don't have time, I will do that after merging this pull request! Thanks again for your code!

examples/claude-light/claude_alab/devices/claude.py:1:8: F401 [*] `json` imported but unused
  |
1 | import json
  |        ^^^^ F401
2 | import requests
3 | from typing import ClassVar
  |
  = help: Remove unused import: `json`

examples/claude-light/claude_alab/tasks/claude.py:1:18: F401 [*] `bson.ObjectId` imported but unused
  |
1 | from bson import ObjectId  # type: ignore
  |                  ^^^^^^^^ F401
2 | from pydantic import BaseModel
  |
  = help: Remove unused import: `bson.ObjectId`

examples/claude-light/claude_alab/tasks/claude.py:2:[22](https://github.com/CederGroupHub/alabos/actions/runs/11246344866/job/31268030198?pr=86#step:9:23): F401 [*] `pydantic.BaseModel` imported but unused
  |
1 | from bson import ObjectId  # type: ignore
2 | from pydantic import BaseModel
  |                      ^^^^^^^^^ F401
3 | 
4 | from alab_management.task_view.task import BaseTask
  |
  = help: Remove unused import: `pydantic.BaseModel`

examples/claude-light/claude_alab/tasks/claude.py:5:40: F401 [*] `claude_alab.devices.claude.ClaudeLight` imported but unused
  |
4 | from alab_management.task_view.task import BaseTask
5 | from claude_alab.devices.claude import ClaudeLight
  |                                        ^^^^^^^^^^^ F401
  |
  = help: Remove unused import: `claude_alab.devices.claude.ClaudeLight`

@jkitchin
Copy link
Contributor Author

jkitchin commented Oct 9, 2024

no problem. I did that in 18fee8f.

@idocx
Copy link
Member

idocx commented Oct 9, 2024

Thank you! Merging it right now!

@idocx idocx merged commit 587ef62 into CederGroupHub:main Oct 9, 2024
4 checks passed
@jkitchin jkitchin deleted the claude-light branch October 9, 2024 12:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants