Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switched ship workflow to use bot token #764

Merged
merged 1 commit into from
Dec 5, 2024

Conversation

CatChen
Copy link
Owner

@CatChen CatChen commented Dec 3, 2024

No description provided.

@CatChen CatChen self-assigned this Dec 3, 2024
Copy link
Owner Author

CatChen commented Dec 3, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Copy link

what-the-diff bot commented Dec 3, 2024

PR Summary

  • Consistency in Event Definitions
    The key for the check_run event has been altered from type to types, ensuring that all event definitions follow a common naming structure.

  • Improved Control Over Job Execution
    The jobs accept-to-ship and pass-to-ship now have a dependency on concurrency-group, which regulates the sequence of tasks, providing an ordered control over job executions.

  • Secure Access to GitHub API
    Steps have been added to create a GitHub app token using actions/create-github-app-token@v1. This upgrade permits a secure way of accessing the GitHub API, eliminating the prior security concerns.

  • Swap Personal Access Token with App Token
    The checkout process is now carried out by the newly created GitHub App Token as opposed to the previous Personal Access Token. This ensures optimal security when checking out.

  • Enhanced Security for accept-to-ship and pass-to-ship Jobs
    The jobs accept-to-ship and pass-to-ship have been tweaked to use the GitHub App Token when invoking CatChen/accept-to-ship-action, promoting increased security and alignment with GitHub's best practices.

Copy link

codecov bot commented Dec 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.07%. Comparing base (6b0d9f4) to head (2c5c339).
Report is 4 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #764   +/-   ##
=======================================
  Coverage   98.07%   98.07%           
=======================================
  Files           1        1           
  Lines          52       52           
  Branches       10       10           
=======================================
  Hits           51       51           
  Misses          1        1           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@CatChen CatChen merged commit 60f0614 into main Dec 5, 2024
20 checks passed
@CatChen CatChen deleted the 12-02-switched_ship_workflow_to_use_bot_token branch December 5, 2024 06:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant