Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stopped using default export #756

Merged
merged 1 commit into from
Nov 25, 2024
Merged

Conversation

CatChen
Copy link
Owner

@CatChen CatChen commented Nov 25, 2024

No description provided.

@CatChen CatChen requested a review from Copilot November 25, 2024 07:47
@CatChen CatChen self-assigned this Nov 25, 2024
Copy link

what-the-diff bot commented Nov 25, 2024

PR Summary

  • Readme Update
    The README file has been revised to provide clearer instructions. The import method for Storage was changed to use a more specific importing style, and all instances of mentioning "Flow" (a programming module) have been replaced with "TypeScript" (a more efficient programming language). Additional instructions on how to use package names with a programming tool called "Deno" were also added.

  • Changes to 'index.js'
    The method of exporting Storage , a key segment in the code, from index.js was modified from a default export to name-specific exports, increasing precision and reducing potential errors.

  • Updates to Storage.ts
    The Storage class was altered to be exported explicitly, which means other parts of the code can now make use of it directly. The change also involved removal of the default export for Storage, making the export more specified and less error-prone.

  • Alterations in Storage-test.ts
    The test file for Storage had its import method for Storage altered, following the change in Storage.ts - from the default method to a name-specific import. This ensures consistency and seamless integration of the test with the main program.

@CatChen CatChen marked this pull request as ready for review November 25, 2024 07:48
Copy link
Owner Author

CatChen commented Nov 25, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 4 out of 4 changed files in this pull request and generated no suggestions.

Copy link

codecov bot commented Nov 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.07%. Comparing base (368f51a) to head (95aa117).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #756   +/-   ##
=======================================
  Coverage   98.07%   98.07%           
=======================================
  Files           1        1           
  Lines          52       52           
  Branches       10       10           
=======================================
  Hits           51       51           
  Misses          1        1           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@CatChen CatChen force-pushed the 11-24-stopped_using_default_export branch from 54d4318 to 95aa117 Compare November 25, 2024 07:49
@CatChen CatChen merged commit bc31d82 into main Nov 25, 2024
16 checks passed
@CatChen CatChen deleted the 11-24-stopped_using_default_export branch November 25, 2024 07:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant