Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migration for JSR #744

Merged
merged 1 commit into from
Nov 24, 2024
Merged

Migration for JSR #744

merged 1 commit into from
Nov 24, 2024

Conversation

CatChen
Copy link
Owner

@CatChen CatChen commented Nov 23, 2024

No description provided.

Copy link

what-the-diff bot commented Nov 23, 2024

Warning
What The Diff skipped summarizing this PR.

The estimated token count of your changes is 4,620.
Your configured maximum tokens per PR is 2,000.

Login to change the settings, or manually trigger a comment here.

Copy link
Owner Author

CatChen commented Nov 23, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

@CatChen CatChen self-assigned this Nov 23, 2024
@CatChen CatChen requested a review from Copilot November 23, 2024 07:33
@CatChen CatChen marked this pull request as ready for review November 23, 2024 07:33
Copy link

codecov bot commented Nov 23, 2024

Codecov Report

Attention: Patch coverage is 98.03922% with 1 line in your changes missing coverage. Please review.

Please upload report for BASE (main@d28a0fd). Learn more about missing BASE report.

Files with missing lines Patch % Lines
src/Storage.ts 98.03% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #744   +/-   ##
=======================================
  Coverage        ?   98.07%           
=======================================
  Files           ?        1           
  Lines           ?       52           
  Branches        ?       10           
=======================================
  Hits            ?       51           
  Misses          ?        1           
  Partials        ?        0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 9 out of 15 changed files in this pull request and generated no suggestions.

Files not reviewed (6)
  • .babelrc: Language not supported
  • .flowconfig: Language not supported
  • index.js.flow: Language not supported
  • jsr.json: Language not supported
  • package.json: Language not supported
  • src/Storage.js: Evaluated as low risk
Comments skipped due to low confidence (5)

src/Storage.ts:5

  • [nitpick] The error message 'localStorage not accessible' could be more descriptive. Consider including the key that caused the error.
throw new Error('localStorage not accessible');

src/Storage.ts:13

  • [nitpick] The error message 'localStorage not accessible' could be more descriptive. Consider including the key that caused the error.
throw new Error('localStorage not accessible');

src/Storage.ts:21

  • [nitpick] The error message 'localStorage not accessible' could be more descriptive. Consider including the key that caused the error.
throw new Error('localStorage not accessible');

src/Storage.ts:29

  • [nitpick] The error message 'localStorage not accessible' could be more descriptive. Consider including the key that caused the error.
throw new Error('localStorage not accessible');

src/Storage.ts:1

  • Ensure that the new TypeScript code is covered by tests, especially the error handling scenarios.
function get(key: string): string | null {
@CatChen CatChen force-pushed the 11-22-migration_for_jsr branch 15 times, most recently from 04f2791 to afbe6b9 Compare November 24, 2024 04:16
@CatChen CatChen force-pushed the 11-22-migration_for_jsr branch from afbe6b9 to eda12fc Compare November 24, 2024 04:29
@CatChen CatChen mentioned this pull request Nov 24, 2024
Copy link
Owner Author

CatChen commented Nov 24, 2024

Merge activity

  • Nov 23, 11:52 PM EST: A user started a stack merge that includes this pull request via Graphite.
  • Nov 23, 11:53 PM EST: A user merged this pull request with Graphite.

@CatChen CatChen merged commit 02f85c2 into main Nov 24, 2024
19 checks passed
@CatChen CatChen deleted the 11-22-migration_for_jsr branch November 24, 2024 04:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant