Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: video_channel ownership #1511 #1513

Merged
merged 1 commit into from
Dec 22, 2023
Merged

fix: video_channel ownership #1511 #1513

merged 1 commit into from
Dec 22, 2023

Conversation

Julusian
Copy link
Member

There is some bad ownership handling of the channels. When creating amcp_command_repository it holds a copy of the pointer for each channel.
This class is not being destroyed correctly, because the main loop holds a reference for the console amcp client, causing it to not be destoyed when expected.

This then crashes because once caspar thinks it has destroyed everything, it tells cef to shutdown which causes the crash as the renderers are still active (as are all the channels, producers and consumers).

This fixes that by swapping out the root channels vector to contain the type needed by amcp_command_repository, which avoids the ownership issues

@Julusian Julusian force-pushed the fix/rework-channels branch from 603ab47 to 4bc0547 Compare December 22, 2023 13:43
@Julusian Julusian marked this pull request as ready for review December 22, 2023 13:43
@Julusian Julusian merged commit b1ce759 into master Dec 22, 2023
8 checks passed
@Julusian Julusian deleted the fix/rework-channels branch December 22, 2023 13:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant