Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modification to HBaseTap to allow it to pull the server's default configuration if no quorums are provided #20

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion project.clj
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
(defproject com.twitter/maple "0.2.2"
(defproject com.twitter/maple "0.2.3-SNAPSHOT"
:source-path "src/clj"
:java-source-path "src/jvm"
:description "All the Cascading taps we have to offer."
Expand Down
6 changes: 6 additions & 0 deletions src/jvm/com/twitter/maple/hbase/HBaseTap.java
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,7 @@
import org.apache.hadoop.conf.Configuration;
import org.apache.hadoop.fs.Path;
import org.apache.hadoop.hbase.*;
import org.apache.hadoop.hbase.HConstants;
import org.apache.hadoop.hbase.client.HBaseAdmin;
import org.apache.hadoop.hbase.mapreduce.TableOutputFormat;
import org.apache.hadoop.mapred.FileInputFormat;
Expand Down Expand Up @@ -144,6 +145,11 @@ public void sinkConfInit(FlowProcess<JobConf> process, JobConf conf) {
if(quorumNames != null) {
conf.set("hbase.zookeeper.quorum", quorumNames);
}
else {
Configuration hbaseConfig = HBaseConfiguration.create(conf);
conf.set(HConstants.ZOOKEEPER_QUORUM, hbaseConfig.get(HConstants.ZOOKEEPER_QUORUM));
conf.set(HConstants.ZOOKEEPER_ZNODE_PARENT, hbaseConfig.get(HConstants.ZOOKEEPER_ZNODE_PARENT));
}

LOG.debug("sinking to table: {}", tableName);

Expand Down