Enable MySQL Streaming

[locked-fg]

In Issue #21 the problem was that MySQL doesn't stream results.
The key issue here is that statement.setFetchSize(Integer.MIN_VALUE); needs to be performed on the statement in DBInputFormat's inner class DbRecordReader. And in the DBRecordReader's constructor there is the required change.

Before, the MySql client first read the complete result into ram and then handed it over to cascading. What you want is that results are streamed through the connection directly into cascading.

What I did:

• extract the "create statement" part into a method "createStatement()" so that it can be overriden by subclasses of DBRecordReader
• Created MySqlDBInputFormat which subclasses DBRecordReader and overloads the createStatement() and returns the according class (in getRecordReaderInternal)
• change MySqlFactory so that it returns the new MySqlDBInputFormat class

[fs111]

Thanks. Could you please squash the commits into one and remove commented out lines?

Before we can use your patch, you will have to sign the contributors agreement: http://files.concurrentinc.com/agreements/Concurrent_Contributor_Agreement.doc

Please sign it and send it back to me at andre[at]concurrentinc[dot]com

[locked-fg]

Ah - can it be that I don't have to make another Pull Request? I just squashed the commits and force-pushed them. I also mailed the contrib.agreement to you

[fs111]

yes, PR's update themselves.

[locked-fg]

So - anything left to do for me? Just want to avoid that we're waiting for each other to do something

[fs111]

I'll try to review and test it in the coming days. I will comment here, if something is missing.

[fs111]

Integrated with some reformatting. Thanks!