Merge pull request #126 from CartoDB/refactor-27f

Extract methods on layer.setSource
CartoDB · Mar 5, 2018 · 9d373db · 9d373db
2 parents 7573d78 + 609636a
commit 9d373db
Showing 1 changed file with 29 additions and 15 deletions.
diff --git a/src/api/layer.js b/src/api/layer.js
@@ -98,27 +98,40 @@ export default class Layer {
      */
     setSource(source) {
         this._checkSource(source);
-        source.bindLayer(
-            dataframe => {
-                this._dataframes.push(dataframe);
-                this._integrator.renderer.addDataframe(dataframe);
-                this._integrator.invalidateWebGLState();
-            },
-            dataframe => {
-                this._dataframes = this._dataframes.filter(d => d !== dataframe);
-                this._integrator.renderer.removeDataframe(dataframe);
-                this._integrator.invalidateWebGLState();
-            },
-            () => {
-                this.state = 'dataLoaded';
-            }
-        );
+        source.bindLayer(this._onDataframeAdded.bind(this), this._onDataFrameRemoved.bind(this), this._onDataLoaded.bind(this));
         if (this._source && this._source !== source) {
             this._source.free();
         }
         this._source = source;
     }
 
+    /**
+     * Callback executed when the client adds a new dataframe
+     * @param {Dataframe} dataframe 
+     */
+    _onDataframeAdded(dataframe) {
+        this._dataframes.push(dataframe);
+        this._integrator.renderer.addDataframe(dataframe);
+        this._integrator.invalidateWebGLState();
+    }
+
+    /**
+     * Callback executed when the client removes dataframe
+     * @param {Dataframe} dataframe 
+     */
+    _onDataFrameRemoved(dataframe) {
+        this._dataframes = this._dataframes.filter(d => d !== dataframe);
+        this._integrator.renderer.removeDataframe(dataframe);
+        this._integrator.invalidateWebGLState();
+    }
+
+    /**
+    * Callback executed when the client finishes loading data
+    */
+    _onDataLoaded() {
+        this.state = 'dataLoaded';
+    }
+
     /**
      * Set a new style for this layer.
      *
@@ -224,6 +237,7 @@ export default class Layer {
         this._styleChanged(this._style);
         this.requestData();
     }
+
     _addToMGLMap(map, beforeLayerID) {
         if (map.isStyleLoaded()) {
             this._onMapLoaded(map, beforeLayerID);