Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/my map #50

Merged
merged 8 commits into from
Dec 20, 2024
Merged

Feature/my map #50

merged 8 commits into from
Dec 20, 2024

Conversation

plduthoit
Copy link
Contributor

@plduthoit plduthoit commented Dec 16, 2024

Contient :

  • Page de base MaCarte
  • Ajout d'un composant MyMapLayerPicker.vue pour la sélection de layer et sublayers
  • Ajout du BasemapPicker
  • Ajout des points resources/projects/actors et filtrage par Thématiques
  • Amélioration du composant de geocoding pour récupérer les bounds d'un lieu pour zoomer la carte précisément dessus plutot que juste des coordinates.

@plduthoit plduthoit linked an issue Dec 16, 2024 that may be closed by this pull request
@plduthoit plduthoit changed the base branch from main to feature/resource-form-improvement December 16, 2024 08:05
@plduthoit plduthoit requested a review from 0live December 16, 2024 08:11
Base automatically changed from feature/resource-form-improvement to main December 18, 2024 13:02
@@ -10,6 +10,7 @@ App\Entity\Actor:
administrativeScopes: '<numberBetween(1, 3)>x @administrative_scope_*'
officeName: <companySuffix()>
officeAddress: <address()>
geoData: '@geoData_<current()>'
officeLocation: '<numberBetween(2, 13)>.<numberBetween(100000, 999999)>, <numberBetween(8, 16)>.<numberBetween(100000, 999999)>'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A remplacer par geoData, et à adapter dans le formulaire de création/édition

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Je mettrais la map dans un store, et des services pour séparer la gestion des couches de la base et celle qui viennent de Qgis server, sinon j'ai peur qu'on ait rapidement un énorme composant.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Même s'il y aura probablement des services qui sont communs aux deux types de données

@@ -32,11 +29,15 @@ const hoveredFeatureId: Ref<string | null> = ref(null)
const activeFeatureId: Ref<string | null> = ref(null)

onMounted(() => {
const accessToken = '0tupl15DKhXOvwp27x8c'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A mettre en variable d'env

}
}
)
// const updatePin = () => {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Un peu de nettoyage à faire :)

@plduthoit plduthoit merged commit 7485aec into main Dec 20, 2024
1 check passed
@plduthoit plduthoit deleted the feature/my-map branch December 20, 2024 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feature my-map
2 participants