Feature/page projets #18

plduthoit · 2024-10-09T07:36:50Z

Contains :

Project list page + filters + order

Components :

Map
Modal
ChipGroup
Chip
Card (modified)

Layout :

Light header

… into feature/page-projets

plduthoit · 2024-10-09T07:38:08Z

symfony/fixtures/administrativeScopes.yaml

+  administrative_scope_3:
+    name: Départemental
+  administrative_scope_4:
+    name: Communal


je l'ai récupéré de ta branche mais dans l'idée plutot le gérer en enum.

0live

Belle branche :)
J'ai quelques remarques, mais l'essentiel est surtout sur la façon dont on articule la carte et le reste de l'application. On pourra en parler directement, ça sera plus simple pour se mettre d'accord

0live · 2024-10-09T07:48:38Z

symfony/src/Entity/Project.php

@@ -76,13 +95,15 @@ class Project
    private ?string $website = null;

    #[ORM\Column(length: 255, nullable: true)]
+    #[Groups([self::PROJECT_READ_ALL])]
    private ?string $logo = null;

    /**
     * @var Collection<int, Actor>
     */
    #[ORM\JoinTable(name: 'financed_projects_actors')]
    #[ORM\ManyToMany(targetEntity: Actor::class)]


Il va falloir qu'on voit avec Maelle, mais je ne suis pas sur qu'il s'agira d'acteurs au sens de la plateforme ici, probablement qu'il s'agira d'une chaine de caractères. A vérifier

0live · 2024-10-09T07:48:50Z

symfony/src/Entity/Project.php

@@ -91,10 +112,12 @@ class Project

    #[ORM\JoinTable(name: 'contracted_projects_actors')]
    #[ORM\ManyToMany(targetEntity: Actor::class)]
+    #[Groups([self::PROJECT_READ_ALL])]


Même chose ici

0live · 2024-10-09T08:15:19Z

vue/src/assets/styles/global/app.scss

@@ -12,10 +12,24 @@
    height: 100vh;
 }

+:root {
+    --dim-container-w: 70rem;


Est ce qu'on ne stockerait pas toutes les variables à un seul endroit?

0live · 2024-10-09T08:18:25Z

vue/src/components/generic-components/ChipList.vue

A réutiliser dans la fiche acteur, j'ai fait ça en css.

yes. On peut d'abord merger la tienne et je réadapterais en prenant ta Chip et ma ChipList.

0live · 2024-10-09T08:21:05Z

vue/src/components/generic-components/Map.vue

Je pense que c'est mieux de mettre la logique de gestion de la map dans une classe hors du composant. Surtout qu'on va avoir plusieurs cartes qui vont partager des fonctionnalités. On peut mettre ça dans un map store et utiliser des services qui fourniront les différentes options.

0live · 2024-10-09T08:56:00Z

vue/src/models/interfaces/Thematic.ts

@@ -1,4 +1,4 @@
 export interface Thematic {


Pareil, on peut utiliser l'interface SymfonyRelation

0live · 2024-10-09T08:57:58Z

vue/src/stores/applicationStore.ts

@@ -14,9 +14,21 @@ export const useApplicationStore = defineStore(StoresList.APPLICATION, () => {
  const activeDialog: Ref<DialogKey|null> = ref(null)
  const showEditContentDialog = ref(false)
  const route = useRoute();
+  const isProjectMapFullWidth = ref(false)


Je le mettrais plus dans le store des projets ça

0live · 2024-10-09T08:58:11Z

vue/src/stores/applicationStore.ts

@@ -14,9 +14,21 @@ export const useApplicationStore = defineStore(StoresList.APPLICATION, () => {
  const activeDialog: Ref<DialogKey|null> = ref(null)
  const showEditContentDialog = ref(false)
  const route = useRoute();
+  const isProjectMapFullWidth = ref(false)
+  const triggerZoomReset = ref(false)


Et ça dans le store de la map

vue/src/stores/applicationStore.ts

0live · 2024-10-09T09:00:14Z

vue/src/stores/thematicStore.ts

Il faudra plugger la partie acteur dessus.

… into feature/page-projets

…t list public

plduthoit added 8 commits October 7, 2024 16:38

feat(project-list): Add project list + map

596d984

Merge branch 'main' of github.com:CartONG/plateforme-urbaine-cameroun…

391fb48

… into feature/page-projets

Merge branch 'main' of github.com:CartONG/plateforme-urbaine-cameroun…

e5fd244

… into feature/page-projets

feat: Add filter modal

80f69b4

fix(ci): rm unused image

c3f4927

fix: ts errors

461959a

fix: ts errors on template refs

cb1ac28

feat(project-list): Add back images to cards

75586f3

plduthoit requested a review from 0live October 9, 2024 07:36

plduthoit commented Oct 9, 2024

View reviewed changes

0live reviewed Oct 9, 2024

View reviewed changes

Merge branch 'main' of github.com:CartONG/plateforme-urbaine-cameroun…

8cfb78b

… into feature/page-projets

plduthoit temporarily deployed to dev October 9, 2024 12:29 — with GitHub Actions Inactive

plduthoit added 2 commits October 11, 2024 12:38

fix(projects): Adjust stores naming + translations +

fef42f8

Merge branch 'main' of github.com:CartONG/plateforme-urbaine-cameroun…

ef2ebb1

… into feature/page-projets

plduthoit had a problem deploying to dev October 11, 2024 10:38 — with GitHub Actions Failure

fix ts

96620dd

plduthoit temporarily deployed to dev October 11, 2024 10:42 — with GitHub Actions Inactive

Merge branch 'main' of github.com:CartONG/plateforme-urbaine-cameroun…

e88ea4a

… into feature/page-projets

plduthoit temporarily deployed to dev October 11, 2024 11:18 — with GitHub Actions Inactive

rm unusedor duplicates command

4c0ca5d

plduthoit temporarily deployed to dev October 11, 2024 11:21 — with GitHub Actions Inactive

set env as one liner

a31f437

plduthoit temporarily deployed to dev October 11, 2024 11:35 — with GitHub Actions Inactive

fix fixturees not loading in prod

484dc9a

plduthoit had a problem deploying to dev October 11, 2024 12:05 — with GitHub Actions Failure

plduthoit added 2 commits October 11, 2024 15:35

Merge branch 'main' of github.com:CartONG/plateforme-urbaine-cameroun…

d045a11

… into feature/page-projets

new migration

26c54e8

plduthoit had a problem deploying to dev October 11, 2024 13:35 — with GitHub Actions Failure

Merge branch 'main' of github.com:CartONG/plateforme-urbaine-cameroun…

b9556a2

… into feature/page-projets

plduthoit had a problem deploying to dev October 11, 2024 14:23 — with GitHub Actions Failure

plduthoit added 2 commits October 11, 2024 16:27

add cache clear to deployement

69aa149

Merge branch 'main' of github.com:CartONG/plateforme-urbaine-cameroun…

51225e9

… into feature/page-projets

plduthoit temporarily deployed to dev October 11, 2024 14:29 — with GitHub Actions Inactive

Merge branch 'main' of github.com:CartONG/plateforme-urbaine-cameroun…

9346d67

… into feature/page-projets

plduthoit temporarily deployed to dev October 11, 2024 14:33 — with GitHub Actions Inactive

plduthoit added 2 commits October 11, 2024 22:23

Merge branch 'main' of github.com:CartONG/plateforme-urbaine-cameroun…

a487d3a

… into feature/page-projets

move card component

8a882cf

0live had a problem deploying to dev October 14, 2024 10:42 — with GitHub Actions Error

0live temporarily deployed to dev October 14, 2024 10:43 — with GitHub Actions Inactive

plduthoit added 2 commits October 14, 2024 15:08

feat(project): Fix things after merge with Actor page and make projec…

81cdcd7

…t list public

fix: Adjust components pathtree

e9c79c9

plduthoit temporarily deployed to dev October 14, 2024 14:20 — with GitHub Actions Inactive

plduthoit merged commit d88c363 into main Oct 14, 2024
1 check passed

plduthoit deleted the feature/page-projets branch October 14, 2024 14:57

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Feature/page projets #18

Feature/page projets #18

plduthoit commented Oct 9, 2024

plduthoit Oct 9, 2024

0live left a comment

0live Oct 9, 2024

0live Oct 9, 2024

0live Oct 9, 2024

0live Oct 9, 2024

plduthoit Oct 9, 2024

0live Oct 9, 2024

0live Oct 9, 2024

0live Oct 9, 2024

0live Oct 9, 2024

0live Oct 9, 2024

Feature/page projets #18

Feature/page projets #18

Conversation

plduthoit commented Oct 9, 2024

Choose a reason for hiding this comment

0live left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment