A0-4341: Bump rust toolchain to 1.79 #1867
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Marcin-Radecki
approved these changes
Nov 29, 2024
There was a problem hiding this comment.
Thankfully, polkadot 1.6.0 compiles on 1.79.0, which I guess is enough to prove we can merge this PR. Only this version introduce offical Rust compatibility >=1.79.0
mike1729
approved these changes
Nov 29, 2024
Merged
via the queue into
Cardinal-Cryptography:main
with commit Dec 2, 2024
9c2036b
15 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Mostly bumps the toolchain, but this also resulted in the detection and removal of some unused code. This PR also removes support for the
try-runtimesubcommand from the node binary – it was deprecated and we are using the external tool already anyway.Type of change
Toolchain bump and cleanup.
Checklist: