Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Duel commander format #6596

Open
wants to merge 14 commits into
base: master
Choose a base branch
from

Conversation

misha-colbourne
Copy link
Contributor

@misha-colbourne misha-colbourne commented Nov 20, 2024

I've added Duel Commander as a format, but in order to have the tab for it show up in the Deck Editor it needs to be present in the appdata editor.xml. I've edited the forge-gui default version of it, but this needs to be somehow applied to the user's appdata version for it to actually work.

May need the correct way to update a user's editor.xml to include the new tab without requiring users to manually update it?

@misha-colbourne
Copy link
Contributor Author

@kevlahnota I've added "banned as commander" support for Duel Commander and Tiny Leaders as per your suggestion

if (rules.getMainPart().getManaCost().getCMC() > 3) {
return false; //only cards with CMC less than 3 are allowed
}
ICardFace otherPart = rules.getOtherPart();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

whats happening to the other checks...?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants