-
Notifications
You must be signed in to change notification settings - Fork 571
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Duel commander format #6596
Open
misha-colbourne
wants to merge
14
commits into
Card-Forge:master
Choose a base branch
from
misha-colbourne:duel-commander-format
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Duel commander format #6596
misha-colbourne
wants to merge
14
commits into
Card-Forge:master
from
misha-colbourne:duel-commander-format
+600
−98
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevlahnota
reviewed
Nov 20, 2024
@kevlahnota I've added "banned as commander" support for Duel Commander and Tiny Leaders as per your suggestion |
tool4ever
reviewed
Nov 22, 2024
tool4ever
reviewed
Nov 22, 2024
if (rules.getMainPart().getManaCost().getCMC() > 3) { | ||
return false; //only cards with CMC less than 3 are allowed | ||
} | ||
ICardFace otherPart = rules.getOtherPart(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
whats happening to the other checks...?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've added Duel Commander as a format, but in order to have the tab for it show up in the Deck Editor it needs to be present in the appdata editor.xml. I've edited the forge-gui default version of it, but this needs to be somehow applied to the user's appdata version for it to actually work.
May need the correct way to update a user's editor.xml to include the new tab without requiring users to manually update it?