Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Android build (SDK 35), Java 17, LibGDX 1.13.0 #6103

Merged
merged 168 commits into from
Oct 21, 2024

Conversation

kevlahnota
Copy link
Contributor

@kevlahnota kevlahnota commented Sep 8, 2024

  • Java 17
  • targetSDK 35 (min 26)
  • add modded uber-apk-signer.jar for signing cert
  • add standalone proguard 7.6.0
  • update some dependency
  • update new default skin
  • update LibGDX (1.13.0)
  • add standalone gdx particle editor
  • create jar installer with izpack

@tehdiplomat
Copy link
Contributor

tehdiplomat commented Sep 8, 2024

Awesome!

Some thoughts:

  • We should bump the versions up to 2.0.0 and announce that we're no longer going to be supporting Java 8 at the same time we merge this PR.
  • It might be nice to do one more full release that supports 1.8 before this gets merged.

@Hanmac
Copy link
Contributor

Hanmac commented Sep 8, 2024

@kevlahnota would be nice if we could implement #4977 in this update

@kevlahnota
Copy link
Contributor Author

@kevlahnota would be nice if we could implement #4977 in this update

Just push a new release / update the plugin https://github.com/Card-Forge/android-maven-plugin
it should work since the PR is merged.

@kevlahnota kevlahnota changed the title update android builds to SDK 29, use Java 11 update android builds to SDK 33, use Java 11 Sep 9, 2024
@kevlahnota kevlahnota closed this Sep 9, 2024
@kevlahnota kevlahnota reopened this Sep 9, 2024
@kevlahnota kevlahnota marked this pull request as draft September 9, 2024 07:53
@Hanmac Hanmac mentioned this pull request Sep 9, 2024
@Hanmac
Copy link
Contributor

Hanmac commented Sep 9, 2024

@kevlahnota kevlahnota changed the title update android builds to SDK 33, use Java 11 update android builds to SDK 29, use Java 11 Sep 9, 2024
@kevlahnota
Copy link
Contributor Author

@kevlahnota for Signing, checkout ~~ https://github.com/MuntashirAkon/apksig-android ~~

Better: https://github.com/jenkinsci/android-signing-plugin

Reverted to sdk 29, seems target sdk 33 and above somehow don't allow installation without proper signature/signing on latest android version (tested with android 14)

@kevlahnota kevlahnota marked this pull request as ready for review September 10, 2024 10:01
@kevlahnota
Copy link
Contributor Author

We might update the forge.sh files too

Yes, i'll just add a plain script for those since the jar have their own check for the needed parameter and will just throw an error if the java installed is lower than 17 i guess.

@kevlahnota
Copy link
Contributor Author

@tehdiplomat @Hanmac seems the new LibGDX is good, no crashes so far on testing here.

@kevlahnota
Copy link
Contributor Author

@tehdiplomat this will create the forge.zip (archive) and forge-installer-2.0.00-SNAPSHOT.jar (installer) in forge-installer/target module. either of those two can be distributed.. though the github actions needs update to reflect this change..

@tehdiplomat tehdiplomat merged commit 4e48dae into Card-Forge:master Oct 21, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Android dependencies Pull requests that update a dependency file Desktop
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants