test(mssql): test all functions #950
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
goldmedal
approved these changes
Nov 27, 2024
|
@grieve54706 conflicts here. |
goldmedal
reviewed
Nov 27, 2024
| scalar,pi,Float,,, "Returns value of PI." | ||
| scalar,getdate,Datetime,,, "Returns current date and time." | ||
| scalar,getutcdate,Datetime,,, "Returns current UTC date and time." | ||
| scalar,sysdatetime,Datetime2,,, "Returns date and time of SQL Server." |
There was a problem hiding this comment.
Suggested change
| scalar,sysdatetime,Datetime2,,, "Returns date and time of SQL Server." | |
| scalar,sysdatetime,Datetime,,, "Returns date and time of SQL Server." |
We can assign it Datetime as well.
| scalar,getutcdate,Datetime,,, "Returns current UTC date and time." | ||
| scalar,sysdatetime,Datetime2,,, "Returns date and time of SQL Server." | ||
| scalar,host_name,String,,, "Returns workstation name." | ||
| scalar,newid,Uniqueidentifier,,, "Returns new GUID." |
There was a problem hiding this comment.
Suggested change
| scalar,newid,Uniqueidentifier,,, "Returns new GUID." | |
| scalar,newid,String,,, "Returns new GUID." |
We can't recognize Uniqueidentifier. String is better.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We added a test case and moved out some functions that need to be revised.
#949