get last_kmsg #3
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
saidinesh5
reviewed
Jan 2, 2017
| @@ -450,6 +450,7 @@ CONFIG_ANDROID_BINDER_IPC=y | |||
| CONFIG_ASHMEM=y | |||
| CONFIG_ANDROID_LOGGER=y | |||
| CONFIG_ANDROID_RAM_CONSOLE=y | |||
| CONFIG_ANDROID_PERSISTENT_RAM=y | |||
There was a problem hiding this comment.
We use cyanogen_cancro_defconfig, and this change is already present there. Hence this is not needed
saidinesh5
reviewed
Jan 2, 2017
| @@ -873,6 +874,33 @@ static void __init reserve_crashkernel(void) | |||
| } | |||
| #else | |||
| static inline void reserve_crashkernel(void) {} | |||
|
|
|||
There was a problem hiding this comment.
On Mi3, i have /proc/last_kmsg, without this change. So is this really needed?
saidinesh5
reviewed
Jan 2, 2017
| @@ -384,8 +384,10 @@ static int __devinit persistent_ram_buffer_init(const char *name, | |||
|
|
|||
| list_for_each_entry(ram, &persistent_ram_list, node) { | |||
| start = ram->start; | |||
| printk("persistent_ram_buffer_init(): ram->num_descs = %d \r\n", ram->num_descs); | |||
There was a problem hiding this comment.
These are just redundant printks, which aren't needed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the original patch is from https://bugzilla.mozilla.org/show_bug.cgi?id=1025265/
works well on Xiaomi Mi4