Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feature/test-watchdog-rewrite] #74

Merged
merged 23 commits into from
Nov 24, 2024
Merged

Conversation

Cameronsplaze
Copy link
Owner

The rewrite was successful! The architecture is more simple, cheaper, and supports more container types now. The only downside vs the old system is SSH by itself probably isn't enough traffic to keep the container up, but you can just get around this by connecting the container's client on-top of ssh-ing in.

Description

Removed a lambda w/ pushing custom metrics. Switched to using ec2's built in "traffic in" metric. Only check "in", because "out" is too noisy, and is pointless in determining if people are connected or not. Just telemetry can throw it off. If traffic is coming in though, either someone is connected, or the container is downloading an update. Either way, you want to stay on.

Motivation and Context

The architecture is more simple, cheaper, and supports more container types now.
Fixes:

How has this been tested?

Deployed all 3 current examples, and make sure they had thresholds that would work.

Screenshots (if appropriate):

N/A

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
    • I have updated the documentation accordingly.
  • All new and existing tests passed.
    • I have added tests to cover my changes.

…ME, so the first metric entry is still good and there's no warning
@Cameronsplaze Cameronsplaze temporarily deployed to Minecraft.java.example.yaml November 24, 2024 02:27 — with GitHub Actions Inactive
@Cameronsplaze Cameronsplaze temporarily deployed to Palworld.example.yaml November 24, 2024 02:27 — with GitHub Actions Inactive
@Cameronsplaze Cameronsplaze temporarily deployed to Valheim.example.yaml November 24, 2024 02:27 — with GitHub Actions Inactive
@Cameronsplaze Cameronsplaze merged commit b10de34 into main Nov 24, 2024
11 checks passed
@Cameronsplaze Cameronsplaze deleted the feature/test-watchdog-rewrite branch November 24, 2024 02:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant