-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[feature/test-watchdog-rewrite] #74
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…into feature/geysermc
… traffic come into the container instead
…ME, so the first metric entry is still good and there's no warning
Cameronsplaze
temporarily deployed
to
Minecraft.java.example.yaml
November 24, 2024 02:27 — with
GitHub Actions
Inactive
Cameronsplaze
temporarily deployed
to
Palworld.example.yaml
November 24, 2024 02:27 — with
GitHub Actions
Inactive
Cameronsplaze
temporarily deployed
to
Valheim.example.yaml
November 24, 2024 02:27 — with
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The rewrite was successful! The architecture is more simple, cheaper, and supports more container types now. The only downside vs the old system is SSH by itself probably isn't enough traffic to keep the container up, but you can just get around this by connecting the container's client on-top of ssh-ing in.
Description
Removed a lambda w/ pushing custom metrics. Switched to using ec2's built in "traffic in" metric. Only check "in", because "out" is too noisy, and is pointless in determining if people are connected or not. Just telemetry can throw it off. If traffic is coming in though, either someone is connected, or the container is downloading an update. Either way, you want to stay on.
Motivation and Context
The architecture is more simple, cheaper, and supports more container types now.
Fixes:
Unblocks:
How has this been tested?
Deployed all 3 current examples, and make sure they had thresholds that would work.
Screenshots (if appropriate):
N/A
Types of changes
Checklist: