Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make it compile on Elixir 1.15 #17

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

haljin
Copy link

@haljin haljin commented Jul 28, 2023

Since Elixir 1.15 introduces code path pruning this library cannot compile anymore without the :private_key application in extra_application.

@haljin
Copy link
Author

haljin commented Aug 10, 2023

Is this library still maintained? :(

@@ -18,7 +18,7 @@ defmodule EasySSL.MixProject do

def application do
[
extra_applications: [:logger]
extra_applications: [:logger, :private_key]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't it be :public_key?

Suggested change
extra_applications: [:logger, :private_key]
extra_applications: [:logger, :public_key]

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not seeing this fix in the current easy_ssl release version: "1.3.0",

defp deps do
    [
      {:easy_ssl, "~> 1.3"},
    ]
  end

mix deps.get && mix deps.compile resulted in:

==> easy_ssl
Compiling 1 file (.ex)

== Compilation error in file lib/easy_ssl.ex ==
** (ArgumentError) lib file public_key/include/OTP-PUB-KEY.hrl could not be found
    (elixir 1.16.3) lib/record/extractor.ex:41: Record.Extractor.from_lib_file/1
    (elixir 1.16.3) lib/record/extractor.ex:18: Record.Extractor.from_or_from_lib_file/1
    (elixir 1.16.3) lib/record/extractor.ex:9: Record.Extractor.extract_all/1
    lib/easy_ssl.ex:10: (module)
could not compile dependency :easy_ssl, "mix compile" failed. Errors may have been logged above. You can recompile this dependency with "mix deps.compile easy_ssl --force", update it with "mix deps.update easy_ssl" or clean it with "mix deps.clean easy_ssl"

But as soon as I added :public_key to my deps/easy_ssl/mix.exs file it compiled with no problem:

==> easy_ssl
Compiling 1 file (.ex)
Generated easy_ssl app

I'm on Ubuntu 22.04.4 LTS and had the same issue with elixir via apt and via asdf.

So I guess there is a merge conflict for this branch maybe?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants