Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keeping objects after workplane creation #971

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Jojain
Copy link
Contributor

@Jojain Jojain commented Jan 26, 2022

Keep selected objects after workplane creation, it breaks quite a lof of tests, we need to investigate if the failing test can be rewritten or if it's really a breaking change
Aims to solve #149

@Jojain Jojain changed the title simple solution test Keeping objects after workplane creation Jan 26, 2022
@adam-urbanczyk
Copy link
Member

Thanks, it might be trickier in terms of backward-compatibility than I expected.

@adam-urbanczyk
Copy link
Member

I think it'd be better to add a kwarg to work plane (say reset:bool = False) to not mess with breaking changes.

@Jojain
Copy link
Contributor Author

Jojain commented Feb 1, 2022

Yeah that's probably easier to deal with. Do we want to reset the selection totally calling findSolid or we just put the last selection state on the stack?

@adam-urbanczyk
Copy link
Member

Yeah that's probably easier to deal with. Do we want to reset the selection totally calling findSolid or we just put the last selection state on the stack?

Why not something like this:

if not reset:
    s.objects = self.objects[:]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants