Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Various sysctl cleanups #107

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Various sysctl cleanups #107

wants to merge 3 commits into from

Conversation

1Naim
Copy link
Member

@1Naim 1Naim commented Oct 24, 2024

Currently there seems to be a bit of a redundancy in the settings set here, so I'd like to clean it up a bit. There are also some removals/tweaks to settings that don't make quite sense to me (based on my limited knowledge), so I've opted to removed them in the PR, but I am very open for discussion.

This is already set by Arch via `/usr/lib/sysctl.d/10-arch.conf` from the `filesystem` package.

Signed-off-by: Eric Naim <[email protected]>
According to [Arch Wiki](https://wiki.archlinux.org/title/Sysctl#Increase_the_maximum_connections) this only helps
on high-loaded servers. Desktops won't become high-loaded servers ever probably, so on the basis of that knowledge remove this.

If increasing this value does indeed has tangible benefits, I can revert this.

Signed-off-by: Eric Naim <[email protected]>
Copy link
Member Author

@1Naim 1Naim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Guess I can't add further snippet reviews so I'll add it here

# This tunable is used to define when dirty data is old enough to be eligible for writeout by the
# kernel flusher threads.  It is expressed in 100'ths of a second.  Data which has been dirty
# in-memory for longer than this interval will be written out next time a flusher thread wakes up
# (Default is 3000).
#vm.dirty_expire_centisecs = 3000

We are also not setting this.

# Only experimental!
# Let Realtime tasks run as long they need
# sched: RT throttling activated
kernel.sched_rt_runtime_us=-1

I'm skeptical about this, maybe we can set it to a higher predefined value than the default instead?

Comment on lines 1 to 8
# The value controls the tendency of the kernel to reclaim the memory which is used for caching of directory and inode objects (VFS cache).
# Lowering it from the default value of 100 makes the kernel less inclined to reclaim VFS cache (do not set it to 0, this may produce out-of-memory conditions)
#vm.vfs_cache_pressure=50
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we want to set this? If not we should just remove it.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AFAIK we used to have a patch that increased this value in our kernel. Not sure how things are now.

Copy link
Member Author

@1Naim 1Naim Oct 25, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CachyOS/linux@9fa4ce3 Doesn't seem to be the case now. On another note, we need to rework these tweaks.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's the consensus of this? I haven't really read much about this so I'm still not too sure about what impacts a lower value might have compared to the default. Is it worth setting this?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Honestly, I'd like to leave it uncommented since we don't have a patch to change it right now, but it's a quite useful tweak, I've been writing more details about it: https://ventureo-codeberg-page.translate.goog/source/kernel-tuning.html?_x_tr_sl=auto&_x_tr_tl=en&_x_tr_hl=en-US&_x_tr_pto=wapp#vfs

We already have this set in the kernel, and having a duplicate here can cause instances when users want to test
the default algorithm in another kernel, but will still have BBR set.

Signed-off-by: Eric Naim <[email protected]>
@1Naim 1Naim marked this pull request as ready for review November 22, 2024 16:25
@1Naim 1Naim requested a review from ventureoo November 22, 2024 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants