Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed Unconditionally editing of cve-id collection in cve endpoints #1309

Merged
merged 8 commits into from
Dec 27, 2024

Conversation

david-rocca
Copy link
Collaborator

Closes Issue #1278

Summary

  • updateCve no longer is always calling updateByCveId when it should only be called when a change from Published to Rejected or from rejected to published.
  • rejectExistingCve no longer makes superfluous changes to the Cve-Id collection if the CNA is replacing one REJECTED record with a different REJECTED record.
  • rejectCVE no longer makes superfluous changes to the Cve-Id collection if the CNA is entering a new REJECTED CVE Record when the CVE ID happens to be in the REJECTED state already.
  • submitCVE no longer makes superfluous changes to the Cve-Id collection if the Secretariat is entering a new REJECTED CVE Record when the CVE ID happens to be in the REJECTED state already.

david-rocca and others added 7 commits December 19, 2024 14:06
…from the defined mocks. We are moving to a better testing solution, so instead of updating the mocks, we will create better integration tests
…ed away from the defined mocks. We are moving to a better testing solution, so instead of updating the mocks, we will create better integration tests"

This reverts commit f465b95.
@jdaigneau5 jdaigneau5 merged commit d4fb734 into dev Dec 27, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants