-
Notifications
You must be signed in to change notification settings - Fork 124
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CBRD-24462] Improve the logic that determines the number of threads to be used when running the backupdb utility, and additionally print the number of threads specified by administrator #5537
base: develop
Are you sure you want to change the base?
Conversation
…to be used when running the backupdb utility, and additionally print the number of threads specified by administrator
…:system_core_count()
src/storage/external_sort.c
Outdated
sort_param->px_height_max = (int) sqrt ((double) num_cpus); /* n */ | ||
sort_param->px_array_size = num_cpus; /* 2^^n */ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sort_param->px_height_max = (int) sqrt ((double) num_cpus); /* n */ | |
sort_param->px_array_size = num_cpus; /* 2^^n */ | |
sort_param->px_height_max = (int) sqrt ((double) num_cpus); | |
sort_param->px_array_size = num_cpus; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
수정하였습니다.
src/transaction/log_recovery.c
Outdated
#include "thread_worker_pool.hpp" | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
#include "thread_worker_pool.hpp" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
수정하였습니다.
http://jira.cubrid.org/browse/CBRD-24462
Purpose
문제 상황
-o 옵션을 사용해 자세한 백업 정보를 출력할 때, 사용자가 입력한 쓰레드 개수가 출력되지 않음
1번 문제 원인
백업에 사용될 쓰레드 개수로 설정하고, 해당 값을 출력해주고 있음
2번 문제 원인
3번 문제 원인
함수 외부에서 추가로 하이퍼쓰레딩을 고려하여 x2 를 해주고 있어 쓰레드 계산식이 잘못되는 문제가 발생함
주요 함수 및 변수
Implementation