Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CBRD-25607] Add test case for When grant/revoke from dba or owner group user, the grantor_name is set to the owner name (feature/plcsql-p1) #1956

Open
wants to merge 4 commits into
base: feature/plcsql-p1
Choose a base branch
from

Conversation

swi0110
Copy link
Contributor

@swi0110 swi0110 commented Nov 12, 2024

@swi0110 swi0110 changed the title [CBRD-25607] Add test case for When grant/revoke from dba or owner group user, the grantor_name is set to the owner name [CBRD-25607] Add test case for When grant/revoke from dba or owner group user, the grantor_name is set to the owner name (feature/plcsql-p1) Nov 12, 2024
@bagus-kim bagus-kim requested review from hiclass and manyoung-jeong and removed request for bagus-kim November 13, 2024 02:14
evaluate 'ERROR: Only DBA and the owner can grant the EXECUTE privilege';
GRANT EXECUTE ON PROCEDURE owner.hello TO temp_user;

select grantor_name, grantee_name, object_name, auth_type, is_grantable from db_auth where grantee_name != 'PUBLIC' order by object_name, auth_type;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
select grantor_name, grantee_name, object_name, auth_type, is_grantable from db_auth where grantee_name != 'PUBLIC' order by object_name, auth_type;
select grantor_name, grantee_name, object_name, auth_type, is_grantable from db_auth where grantee_name != 'PUBLIC' order by grantor_name, grantee_name ;

object_name, auth_type 의 각 값이 동일하기 때문에 변경하는 것이 좋겠습니다.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

반영했습니다.
리뷰 감사합니다.

GRANT select ON owner.tbl TO grantable_member WITH GRANT OPTION;
GRANT select ON owner.tbl TO temp_user;

select grantor_name, grantee_name, object_name, auth_type, is_grantable from db_auth where grantee_name != 'PUBLIC' order by object_name, auth_type;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
select grantor_name, grantee_name, object_name, auth_type, is_grantable from db_auth where grantee_name != 'PUBLIC' order by object_name, auth_type;
select grantor_name, grantee_name, object_name, auth_type, is_grantable from db_auth where grantee_name != 'PUBLIC' order by grantor_name, grantee_name;

object_name, auth_type 의 각 값이 동일하기 때문에 변경하는 것이 좋겠습니다.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

반영했습니다.
리뷰 감사합니다.

CALL LOGIN('grantable_member','') ON CLASS db_user;
GRANT select ON owner.tbl TO temp_user;

select grantor_name, grantee_name, object_name, auth_type, is_grantable from db_auth where grantee_name != 'PUBLIC' order by object_name, auth_type;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
select grantor_name, grantee_name, object_name, auth_type, is_grantable from db_auth where grantee_name != 'PUBLIC' order by object_name, auth_type;
select grantor_name, grantee_name, object_name, auth_type, is_grantable from db_auth where grantee_name != 'PUBLIC' order by grantee_name, object_name, auth_type;

object_name, auth_type 의 각 값이 동일것이 있기 때문에 변경하는 것이 좋겠습니다.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

반영했습니다.
리뷰 감사합니다.

GRANT select ON owner.tbl TO dba;
GRANT EXECUTE ON PROCEDURE owner.hello TO dba;

select grantor_name, grantee_name, object_name, auth_type, is_grantable from db_auth where grantee_name != 'PUBLIC' order by object_name, auth_type;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
select grantor_name, grantee_name, object_name, auth_type, is_grantable from db_auth where grantee_name != 'PUBLIC' order by object_name, auth_type;
select grantor_name, grantee_name, object_name, auth_type, is_grantable from db_auth where grantee_name != 'PUBLIC' order by grantee_name,object_name, auth_type;

object_name, auth_type 의 각 값이 동일한 것이 있기 때문에 변경하는 것이 좋겠습니다.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

반영했습니다.
리뷰 감사합니다.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants