Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bn updates and tests #69

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Bn updates and tests #69

wants to merge 2 commits into from

Conversation

KarenBaliero
Copy link

Why was it necessary?

  • Correcting work of .contais methods and add variables for Tests
  • Add test files for Behavior and BehaviorsWTA, classes of Behavior Network

How was it done?

Created tests based on Behavior Netork Demo

Implementation details

Changed the .contains to compare the Memory Info instead

How to test?

Unit tests created

Future works

Allows implementation of BehaviorNetwork Demo

* Modify contains to for loops
* Add variables for tests
* Add Behavior tests
* Add BehaviorsWTA tests
@KarenBaliero KarenBaliero requested a review from rgudwin as a code owner January 15, 2025 15:47
@KarenBaliero KarenBaliero changed the title Bn updates Bn updates and tests Jan 15, 2025
{
sharpM = sharpM + 1;
}
for(Memory item : MODULE_softPrecon_and_ClassicPrecon) {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Avoid deeply nested control flow statements.

{
sharpA = sharpA + 1;
}
for(Memory addItem : module.getAddList()) {

This comment was marked as duplicate.

{
sharpU = sharpU + 1;
}
for(Memory deleteItem : module.getDeleteList()) {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Avoid deeply nested control flow statements.

}
if (!hasFound) {
for(Memory softPreconItem : comp.getSoftPreconList()) {
if (softPreconItem.getI().equals(proposition.getI())) {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Avoid deeply nested control flow statements.

}
}
return compWithProp;
private double competencesWithPropInDel(Memory proposition) {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Similar blocks of code found in 2 locations. Consider refactoring.

Copy link

codeclimate bot commented Jan 15, 2025

Code Climate has analyzed commit 2032096 and detected 9 issues on this pull request.

Here's the issue category breakdown:

Category Count
Complexity 5
Duplication 4

Note: there is 1 critical issue.

The test coverage on the diff in this pull request is 29.5% (90% is the threshold).

This pull request will bring the total coverage in the repository to 40.5% (4.2% change).

View more on Code Climate.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant