-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bn updates and tests #69
base: master
Are you sure you want to change the base?
Conversation
* Modify contains to for loops * Add variables for tests
* Add Behavior tests * Add BehaviorsWTA tests
{ | ||
sharpM = sharpM + 1; | ||
} | ||
for(Memory item : MODULE_softPrecon_and_ClassicPrecon) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Avoid deeply nested control flow statements.
{ | ||
sharpA = sharpA + 1; | ||
} | ||
for(Memory addItem : module.getAddList()) { |
This comment was marked as duplicate.
This comment was marked as duplicate.
Sorry, something went wrong.
{ | ||
sharpU = sharpU + 1; | ||
} | ||
for(Memory deleteItem : module.getDeleteList()) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Avoid deeply nested control flow statements.
} | ||
if (!hasFound) { | ||
for(Memory softPreconItem : comp.getSoftPreconList()) { | ||
if (softPreconItem.getI().equals(proposition.getI())) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Avoid deeply nested control flow statements.
} | ||
} | ||
return compWithProp; | ||
private double competencesWithPropInDel(Memory proposition) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Similar blocks of code found in 2 locations. Consider refactoring.
Code Climate has analyzed commit 2032096 and detected 9 issues on this pull request. Here's the issue category breakdown:
Note: there is 1 critical issue. The test coverage on the diff in this pull request is 29.5% (90% is the threshold). This pull request will bring the total coverage in the repository to 40.5% (4.2% change). View more on Code Climate. |
Why was it necessary?
How was it done?
Created tests based on Behavior Netork Demo
Implementation details
Changed the .contains to compare the Memory Info instead
How to test?
Unit tests created
Future works
Allows implementation of BehaviorNetwork Demo