-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Separate secrets from main config #8 #114
Conversation
Since you are changing a CI/CD pipeline, can you attach a link to the pipeline which is successfully working? |
Here it is: https://github.com/CSR-LC/csr-be/actions/runs/11068058471 |
.github/workflows/blank.yml
Outdated
@@ -95,6 +95,17 @@ jobs: | |||
script: | | |||
mkdir -p /var/www/csr/stage/ | |||
echo '${{ secrets.DEPLOY_CONFIG }}' > /var/www/csr/stage/config.json | |||
sudo rm -rf /etc/systemd/system/stage.csr.service.d |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think EnvironmentFile
directive might be simplier to work with compared to folder management.
https://www.flatcar.org/docs/latest/setup/systemd/environment-variables/
Could you try this approach and see how it works?
Please create environment file in the same directory with stage.csr.service
- do not create unnecessary folders as possible.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your advice! Updated this flow. Here are successful run: https://github.com/CSR-LC/csr-be/actions/runs/11105969158
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The solution is working - good, but env file management could be optimized - https://github.com/CSR-LC/csr-be/pull/114/files#r1778498849
Now looks good (IMHO) and works fine, thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
resolves: https://github.com/CSR-LC/issues/issues/8