Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Udpates email address (BAL-199) #200

Merged
merged 1 commit into from
Dec 4, 2024

Conversation

sebastianricaldoni
Copy link
Collaborator

@sebastianricaldoni sebastianricaldoni commented Dec 4, 2024

Name of the PR

♻️ Current situation & Problem

The current problem is stated in #199

⚙️ Release Notes

  • We are now sending the activity report to Ainsley Elizabeth Cogburn's email address

📚 Documentation

✅ Testing

We can test when deployed to TestFlight as the change is trivial

📝 Code of Conduct & Contributing Guidelines

By submitting creating this pull request, you agree to follow our Code of Conduct and Contributing Guidelines:

Copy link
Collaborator

@gperissetcelteeka gperissetcelteeka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sebastianricaldoni sebastianricaldoni merged commit 930c261 into main Dec 4, 2024
3 checks passed
@sebastianricaldoni sebastianricaldoni deleted the feature/BAL-199-SR-UpdateEmailAddress branch December 4, 2024 16:10
Copy link

codecov bot commented Dec 4, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 3.88%. Comparing base (bf82388) to head (c505232).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
Balance/Profile/ProfileView.swift 0.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff            @@
##            main    #200      +/-   ##
========================================
- Coverage   4.07%   3.88%   -0.18%     
========================================
  Files        130     130              
  Lines      11079   10941     -138     
========================================
- Hits         450     424      -26     
+ Misses     10629   10517     -112     
Files with missing lines Coverage Δ
Balance/Profile/ProfileView.swift 0.00% <0.00%> (ø)

... and 17 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bf82388...c505232. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants