Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix endless loop in GPSPropagator.java #21

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

JosefProbst
Copy link

If x.getValue() or/and x0.getValue() is Double.NaN this is a endless loop.

If x.getValue() or/and x0.getValue() is Double.NaN this is a endless loop.
@wardev
Copy link
Contributor

wardev commented Apr 29, 2019

Thanks for the patch! Could you add a unit test?

@BryanCazabonne
Copy link
Collaborator

Hi all,

Many thanks for finding and correcting the issue.
The GitHub repository is only a mirror repository for Orekit. In that respect, it is not really adapted for pull request.
Can you create an account on the Orekit GitLab repository ( https://gitlab.orekit.org/orekit/orekit ) ?
Then, create an issue on: https://gitlab.orekit.org/orekit/orekit/issues
Finally, send a merge request on the GitLab repository

Many thanks
Bryan

@BryanCazabonne
Copy link
Collaborator

Hi JosefProbst,

Your patch does not compile in my computer. I have an error when I call the method .equals() with a "double" parameter : " Cannot invoke equals(double) on the primitive type double "

I moved the issue on the Orekit GitLab repository. We remarked that this endless loop can also occur on KeplerianOrbit.java and FieldKeplerianOrbit.java classes.

Thanks again for finding the issue.
Bryan

@BryanCazabonne
Copy link
Collaborator

The issue has been fixed in develop branch (https://gitlab.orekit.org/orekit/orekit/issues/544).

Thanks again for your contribution on the bug reporting. I notified your contribution in the change.xml file of Orekit.

Best regards,
Bryan

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants