Loading Grids with properties #485
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* add default interploationType * add getInterpolationType * add getInterpolationTypeName
lukasmerten
requested changes
Jun 3, 2024
| if (ipolType == NEAREST_NEIGHBOUR) | ||
| return "NEAREST_NEIGHBOUR"; | ||
|
|
||
| return "NOT_UNDERSTOOD"; |
There was a problem hiding this comment.
Could you add a more meaningful error message. Something like "ipolType not well defined: should be either TRILINEAR, TRICUBIC, or NEAREST_NEIGHBOUR".
There was a problem hiding this comment.
This is not meant to be an error message. It is the conversion from the data-type to a string for saving.
To be consistent with the reading it has to be without spaces.
The alternative would be raising a runtime error at this point. In this case the saving would not run at all.
lukasmerten
approved these changes
Jun 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dear all,
this PR introduces the loading of grids with given properties in the header.
The first implementation only allows property reading in the TXT files.
An example of the properties in the header looks like this
all units are in SI base units (in this case m). The loading itself has the conversion variable as before.
Loading a grid can now be done as
I also introduce the possibility to store the properties in the
dumpGridToTxtfunction and additional tests for this grid reading/dumping.To have an example, I adjusted the notebook with the grid-based glactic gas densities to use the grid property reading. The files on sciebo (additional resources) are already updated (additional line with the properties in the right format).