update gateset #37
Merged
update gateset #37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cqc-alec
reviewed
Nov 7, 2023
Comment on lines
112
to
116
| OpType.CZ, # | ||
| OpType.Rx, # | ||
| OpType.Rz, # | ||
| OpType.Measure, # | ||
| OpType.Barrier, # |
There was a problem hiding this comment.
I was using the wrong formatter version, solved now. See 641de02
tests/qvm_backend_test.py
Outdated
| c.measure_all() | ||
|
|
||
| h = forest_backend.process_circuit(c, 10) | ||
| forest_backend.get_result(h) |
There was a problem hiding this comment.
It would be better to assert something about the result to check that the gate is being translated correctly.
There was a problem hiding this comment.
I have expanded the testcase here to check the result, see 641de02.
Was that what you wanted to see?
cqc-alec
reviewed
Nov 7, 2023
tests/qvm_backend_test.py
Outdated
| res = forest_backend.get_result(h) | ||
|
|
||
| assert res.get_shots().shape == (10, 6) | ||
| assert res.get_counts()[(0, 0, 0, 0, 0, 0)] < 10 |
There was a problem hiding this comment.
I'd delete this line since it will fail about 0.1 % of the time and the next assert gives enough assurance.
cqc-alec
approved these changes
Nov 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
solves #5
Add the XY gate to the gateset.