fix: Run C.I. checks for the docs build on PRs #372
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes the C.I. build of the docs to always run on pull requests. I think after #339 I hadn't updated the workflow correctly so the C.I. checks were skipped. This was because of the way the filtering was set up.
I have solved this for now by removing the "changes" job in C.I. that does the filtering. Let me know if there are any objections to this. I think we would want to run C.I. for most changes we make in this repository anyway. I think the only files I it would make sense to skip the checks for are README files, the licence file and
.gitignoreAlternatively I could update the filtering to check for updates to the new files.
This PR should be merged before #370 to be on the safe side.
Related issues
Fixes #368