Add reduce functionality and example #284
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CianLR
approved these changes
Apr 20, 2017
dipla/server/task_queue.py
Outdated
| self.task_item.instructions, | ||
| self.task_item.machine_type, | ||
| arguments, | ||
| signals=[x for x in self.task_item.signals]) |
There was a problem hiding this comment.
I would prefer list(self.task_item.signals) but it's a nitpick 🇱🇾
dipla/server/task_queue.py
Outdated
| "Attempted to read input from an empty source") | ||
| arguments = [] | ||
|
|
||
| for i in range(self.reduce_group_size): |
There was a problem hiding this comment.
Convention is for _ in qwertyuiop if you're not using the actual value 🇱🇾
examples/reduce.py
Outdated
|
|
||
| input_data = [word.lower() for word in communist_manifesto.split() if len(word) > 0] | ||
|
|
||
| @Dipla.reduce_distributable(n = 6) |
There was a problem hiding this comment.
I know we don't PEP8 the examples... but qwerty(n=6)
byxor
approved these changes
Apr 21, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Connects to #266.
This creates a
@Dipla.reduce_distributabledecorator. You can see its use inexamples/reduce.py, which finds the word with the most vowels in the opening of the communist manifesto by a reduce function.The decorator takes a parameter,
n. This is the number of inputs to take in one go. A normal reduce takes 2 inputs, however it was suggested that this number could be raised to get better performance by reducing the number of requests sent across the wire. This is left up to the user.It is a little over the 150 line limit, but that is probably caused by the inclusion of the example.
Let me know what you think xoxo