Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an example for a chasing distributable #276

Merged
merged 2 commits into from
Apr 21, 2017

Conversation

StefanKennedy
Copy link

@StefanKennedy StefanKennedy commented Apr 16, 2017

Connects to #267

This example has a grid of 1s or 0s, with at most one 1 per column, and in the end it gives us information about how far away from the bottom row the 1 was. It splits each row into halves and sends the first half early so that processing can start on it. This way tasks can depend on other tasks without them having to be totally completed

@StefanKennedy StefanKennedy changed the base branch from master to s/chasing_functions#267 April 16, 2017 16:06
@iandioch
Copy link
Member

With your PR title it seems like you were a wee bit tipsy?

@StefanKennedy StefanKennedy changed the title Add an example for a chasing example Add an example for a chasing distributable Apr 18, 2017
@StefanKennedy
Copy link
Author

Must have been 👻

Copy link
Member

@byxor byxor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

out = Dipla.get(results)
outlist = []
for o in out:
outlist = outlist + o
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it would be clearer if you used outlist.extend(o)

@byxor byxor merged commit e55dab4 into s/chasing_functions#267 Apr 21, 2017
@byxor byxor deleted the s/chasing_example branch April 21, 2017 01:20
@byxor byxor removed the in progress label Apr 21, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants