♻️ Improved jsonschema exporter #432
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sschleemilch
force-pushed
the
feature/improved-jsonschema-exporter
branch
from
c7e187b to
71757b9
Compare
|
MoM:
|
SebastianSchildt
approved these changes
Dec 3, 2024
|
MoM:
|
erikbosch
reviewed
Dec 4, 2024
erikbosch
reviewed
Dec 4, 2024
| target_type = type_map[datatype] | ||
| target_type = type_map[datatype] | ||
| ref["type"] = target_type[0] | ||
| if len(target_type) > 1: |
There was a problem hiding this comment.
As of today we expect "len" to be either 1 or 3, right? I.e. never anything else.
There was a problem hiding this comment.
Right now it only will be 1 or 3. Yeah. Thought about specifying at least the lower boundary for uint64. Then we would have 2 :)
Nope, old ones were not including array restrictions and the new one is. So it will definitely break |
Signed-off-by: Sebastian Schleemilch <[email protected]>
sschleemilch
force-pushed
the
feature/improved-jsonschema-exporter
branch
from
71757b9 to
9a85ec8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improved the jsonschema exporter
Added typed arrays using
itemsBefore:
{ "$schema": "https://json-schema.org/draft/2020-12/schema", "title": "Vehicle", "type": "object", "description": "Vehicle", "additionalProperties": false, "properties": { "Attribs": { "description": "Attribs", "type": "array" } } }Now:
{ "$schema": "https://json-schema.org/draft/2020-12/schema", "title": "Vehicle", "type": "object", "description": "Vehicle", "properties": { "Attribs": { "type": "array", "description": "Attribs", "items": { "type": "string" } } }, }Added support for custom types a.k.a
structs:{ "$schema": "https://json-schema.org/draft/2020-12/schema", "title": "Vehicle", "type": "object", "description": "Vehicle", "properties": { "Doors": { "type": "array", "description": "Doors", "items": { "type": "object", "description": "Door", "properties": { "Windows": { "type": "integer", "description": "Windows", "minimum": 0, "maximum": 255 } }, "additionalProperties": false } } }, "additionalProperties": false }Including
minimumandmaximumautomatically for types to express their max mins (only until uint/int64 exclusive){ "$schema": "https://json-schema.org/draft/2020-12/schema", "title": "Vehicle", "type": "object", "description": "Vehicle", "properties": { "Speed": { "type": "integer", "description": "Speed", "minimum": -32768, "maximum": 32767 } }, "additionalProperties": false }Fixed support for
numericAdded
minandmaxare in the range of the datatype