Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing uuid feature #409

Merged
merged 1 commit into from
Oct 23, 2024
Merged

Removing uuid feature #409

merged 1 commit into from
Oct 23, 2024

Conversation

erikbosch
Copy link
Collaborator

@erikbosch erikbosch commented Oct 3, 2024

This would be the last step in removing the old UUID functionality. I have generally tried to remove UUID support in all tools, i.e. fields/columns with UUID are removed. One exception though - I am keeping the UUID byte for binary output as I believes tools using that format (VISSR) could have difficult handling a changd format.

What I would like to bring up in a VSS meeting

  • Are we (finally) ready to do this?
  • Would the changes in this PR be problematic for anyone (we can like currently for binary keep a column/field even if value always remain zero/null/empty)

@erikbosch erikbosch marked this pull request as ready for review October 3, 2024 14:03
@SebastianSchildt
Copy link
Collaborator

So I do thing wie should do this, now that we have a 5.0 released that still supports it (and we can still backport fixes for some time to come). Moving forward, loosing some code

@erikbosch
Copy link
Collaborator Author

MoM:

  • Please review
  • Check if it has any impacts on you

@erikbosch
Copy link
Collaborator Author

MoM: Merge

Note: Keeping UUID as bit in binary output
Signed-off-by: Erik Jaegervall <[email protected]>
@erikbosch erikbosch merged commit 6fb0625 into COVESA:master Oct 23, 2024
5 checks passed
@erikbosch erikbosch deleted the erik_uuid branch October 23, 2024 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants