Updating CHANGELOG and minor chnage in UUID handling #406
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erikbosch
force-pushed
the
erik_uuid
branch
2 times, most recently
from
0d0bb52 to
fc5284d
Compare
Signed-off-by: Erik Jaegervall <[email protected]>
erikbosch
force-pushed
the
erik_uuid
branch
from
fc5284d to
73d8bde
Compare
That is not required but optional to do it like that: https://click.palletsprojects.com/en/8.1.x/options/#boolean-flags |
As they recommend having both I have no problems with it. |
erikbosch
added
the
Release Blocker
erikbosch
commented
Sep 17, 2024
|
|
||
| General args have been extended with logging arguments `--log-level` and `--log-file`. | ||
|
|
||
| ## SAMM Exporter added |
erikbosch
added
the
Scope:Trivial
|
MoM: Ok to merge as part of release prep as trivial |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I took a look at the changelog, and this PR contains some changes related to that
-no--uuidwas re introduced again (I think the new CLI framework expects boolean parameters to be a "pair"). But I assume still we want to remove it completely for VSS 6.0 so I added a deprecation note if--uuidis used