-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
📦 Creating nightly release on master push #401
Conversation
.github/workflows/wheel.yml
Outdated
@@ -0,0 +1,34 @@ | |||
name: nightly |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like the idea. I was just thinking of the name "nightly", as this file as of today does not really run nightly (with cron) but rather only on merge of pull requests.
(Theoretically we may get regressions even without changes in our repo, like if an action gets outdated or updated without changing major version)
Alternatives:
- Keep it as is (works for me)
- Use some other name/tag than "nightly"?
- Add a cron as well so it runs nightly as well?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
True, I was also playing with the wording. Nightly is technically not completely correct as you correctly mentioned since it is triggered on master pushes. How about latest
? The problem I have with latest
is that it usually means latest release but we are not talking about a release here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changed trigger to schedule at midnight and therefore making it a real nightly
it seems a bit waste to build "nightly", if nothing haopens you build the aame thing over and over again, if somebody wants to test something, and is not inclined to build the wheel he needs to sleep the night. I think something like
would be better. Can just call it "dev" ("latest" not goot that would imply a stable version) |
An actually, I think it shoudl even build on PRs but then not create a release but just archive the wheel . Again, to give people somehting to test Something like (not tested)
|
I guess that depends on how you intend to use the wheel. If someone downstream (Kuksa, BMW, anyone, ...) actually wants to test with the "latest wheel" on possibly nightly basis a release has the advantage that it gives a static link, compared to builds. |
On PRs I do not think it will be that useful. People reviewing PRs probably know how to checkout a PR branch and do poetry install. I think downloading a wheel and then doing pip install on it is also not less effort. And as Erik said, build artifact URLs are not static. However, I agree that a nightly schedule is overkill since it would nearly never change. |
Signed-off-by: Sebastian Schleemilch <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Lets make a merge decision tonight
After merging that we can extend the vss-tools readme how to install the nightly via pip |
MoM:
|
After thinking about it: do you think it will really increase value for Users? |
To be reopened when needed |
Creating a gh-release tagged as
nightly
with*.whl
added as asset on every master push.Even it is not built nightly but on a master push,
nightly
represents best what the content is. The latest master branch as a wheel.If we want to get a bit cleaner here I would vote for maintaining CHANGELOG.md on every PR and bumping the version in
pyproject.toml
accordingly based on the change that has been done. Then we can create real pre-releases for every version ending on master.The latest nightly wheel can then be downloaded via: